From 1d338bbe94b9ee4c05f34a28bbee8d8251aa44af Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Thu, 15 Mar 2012 22:38:06 -0400 Subject: [PATCH] Replace non-functional images with CSS styled text The plus-sign and minus-sign images, used only for showing more or fewer copies, did not actually do anything when you clicked on them. In addition, they can be reasonably represented as plain text + CSS, saving an extra HTTP request per copy detail page that has more than 10 copies. Moving the text + CSS into the tag also makes them clickable, which is kind of nice. And, being CSS, it's easy to change the colour scheme to suit a different site. Signed-off-by: Dan Scott --- Open-ILS/src/templates/opac/parts/record/copy_table.tt2 | 8 ++++---- Open-ILS/web/css/skin/default/opac/style.css | 12 ++++++++++++ Open-ILS/web/images/minus_sign.png | Bin 1102 -> 0 bytes Open-ILS/web/images/plus_sign.png | Bin 1103 -> 0 bytes 4 files changed, 16 insertions(+), 4 deletions(-) delete mode 100644 Open-ILS/web/images/minus_sign.png delete mode 100644 Open-ILS/web/images/plus_sign.png diff --git a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 index 240f9703cd..71e55028e6 100644 --- a/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 +++ b/Open-ILS/src/templates/opac/parts/record/copy_table.tt2 @@ -125,13 +125,13 @@ END; [%- more_copies_limit = 50 %] [%# TODO: config %] [%- IF ctx.copy_limit != more_copies_limit AND ctx.copies.size >= ctx.copy_limit %]
- - [% l('Show more copies') %] + +[% l('Show more copies') %]
[%- ELSIF ctx.copy_limit == more_copies_limit %]
- - [% l('Show fewer copies') %] + -[% l('Show fewer copies') %]
[%- END %] diff --git a/Open-ILS/web/css/skin/default/opac/style.css b/Open-ILS/web/css/skin/default/opac/style.css index 10dacd9a89..8591c8e313 100644 --- a/Open-ILS/web/css/skin/default/opac/style.css +++ b/Open-ILS/web/css/skin/default/opac/style.css @@ -1406,3 +1406,15 @@ table.result_holdings_table thead tr { table.result_holdings_table thead tr th { font-weight: bold; } +.charsign { + vertical-align: middle; + font-weight: bold; + padding: 5px 10px; + margin: .5em; + color: white; + background-color: #00593d; + border-radius: 4px; +} +a.charsign, a.charsign:hover { + text-decoration: none +} diff --git a/Open-ILS/web/images/minus_sign.png b/Open-ILS/web/images/minus_sign.png deleted file mode 100644 index 553efcfad0e05eed49699aaee99bcb049e3ebe9d..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1102 zcmaJ=O=#0l91okK42NF_QBj`h#e;2GpF5k%QZ)Po-faXUCKq8F_%wXGhk50dx(FTdaK|CzI?Bk(I&>9!U#om z13i<)*~EaLBEzS+7+=}22%DlJd&`!h79a*AFt3{;z5MVI4RlSUhxi1Wu%d8OKQw8> z^kg!lP8QU#M(^DNB4vRH7!WIb(XP!{Qiu0YQ2HA9021Q$g5cTm|x3Ph0&0q1n-1me=E0C|YN+Hi(20Z)Hyx~)DvV1aP53@t*Mz|a;T3iXKMFX0+#nt|BgB`icf|-&&dzLrUo*xV-GKhSBgV( z=OdSKeCD+C;&$+&xwN!YtJS!Q9-bag-a50mxHx#XBHuYzuh$Pw?GOof9hQ@6V*b6T zcb=o0$+xk%)SoH89)1zua0;x8F5FvF>9Xr@uHIkxIC$joqxG}3>G@4H>dC5|&x4-X zZQpY9`M0xQcik9X&IEcdU3^gSUfcI^_p4{}hw7&Bn=_LuPZX-)5MEp|mSW>#P|M=7|0daY| diff --git a/Open-ILS/web/images/plus_sign.png b/Open-ILS/web/images/plus_sign.png deleted file mode 100644 index 1f12d14bba024aebc8d82c565c4534ed1bdb7556..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1103 zcmaJ=O=uHA6kbTBwNigtp;S<|8>j_M_9to5tlgF-o3?>&2}z_;Y{_`D z4OOHFB6t%K6#O};2eAjylY*4uK~Ek_X|dRYNJTw~6g1AZP3yrpuru>!zVCbQ&3k(- zKGfe(f25uuh=$mJn80fj{tnc+@XX$>Ifj=O6iuTf%%Xy90isuhV}Ok5atM5GCG7b?-nDKnF-Bi~59N^F@K$)aCKsIi@Lc6N1JCYAdL;6elCl z0%V7m@hD7yAp@+J_4$Lr;7O8WScYaen&mufkoR#s!;ss9!rm-3%O}LXZC}_Ds60X@ zPt%1$!CUZop_QZAP$=YRaGVDtJodDKtfx?PtOdMi*t1X1$D)QUxeU|A*@O4%$Wuup93`h3(X|3Fri{;iRSD!e!l#E0d2{ zKt|9?K{!!)#dsbfXy>6xMv@)mux6;RU~i%&iH{jJk_`pKM1jJ5ucoQIuhSp$_i-J8 zXei3EQMOm)d|`i3WI2Wlabmc_6`?Yz0|QmK>Ml1>mFqNuZeq_Ou(TaqB$>TPq?>aqB%a%mh4?UePeGFOgp?>O6?rp3li+XDmlx`mti=<>5T{vnw7U@FR7 z&$nJY6TAV%`!fp*3)-6pC$1{(S28_!3a4(_)TOiGyQQ|-(Q>(*&1Uhu@aRPba}T1# zP!gMe4`S6l(t_{wnAn>tE}eTn-{@+sbHxuYjy(DNyZj;0-n{Wj^_3jyUb$O$C