From 20d244c4c304c4853d4f96a4e9aa5f43a1ff8ec7 Mon Sep 17 00:00:00 2001 From: Cesar Velez Date: Fri, 22 Feb 2019 10:41:46 -0500 Subject: [PATCH] LP#1068287 - new precat permission - make_precat_copy perm check Misc refactoring. Signed-off by: Cesar Velez --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm index 872d8b00b5..756c66f9cd 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm @@ -1623,8 +1623,6 @@ sub do_checkout { } if( $self->is_precat ) { - return $self->bail_on_events(OpenILS::Event->new('PERM_FAILURE')) - unless $self->editor->allowed('CREATE_PRECAT'); $self->make_precat_copy; return if $self->bail_out; @@ -2428,6 +2426,8 @@ sub create_due_date { sub make_precat_copy { my $self = shift; my $copy = $self->copy; + return $self->bail_on_events(OpenILS::Event->new('PERM_FAILURE')) + unless $self->editor->allowed('CREATE_PRECAT'); if($copy) { $logger->debug("circulator: Pre-cat copy already exists in checkout: ID=" . $copy->id); -- 2.11.0