From 25969df39f18f8cc78a95f98ddc6dc4e7e3ac3d4 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Wed, 14 Aug 2019 12:41:55 -0400
Subject: [PATCH] LP1840050 FM Editor WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---
 .../app/share/fm-editor/fm-editor.component.html   |  2 +-
 .../src/app/share/fm-editor/fm-editor.component.ts | 34 +++++++++++++---------
 2 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
index 48c05f4827..2621b3e948 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
@@ -5,7 +5,7 @@
 <eg-string #failStr text="Update Failed" i18n-text></eg-string>
 
 <ng-template #dialogContent>
-  <div class="modal-header bg-info">
+  <div class="modal-header bg-info" *ngIf="!hideBanner">
     <h4 class="modal-title" i18n>Record Editor: {{recordLabel}}</h4>
     <ng-container *ngIf="isDialog()">
       <button type="button" class="close" 
diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
index a3a6138641..33da1f49ff 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
@@ -118,14 +118,18 @@ export class FmRecordEditorComponent
     // Display within a modal dialog window or inline in the page.
     @Input() displayMode: 'dialog' | 'inline' = 'dialog';
 
+    // Hide the top 'Record Editor: ...' banner.  Primarily useful
+    // for displayMode === 'inline'
+    @Input() hideBanner: boolean;
+
     // Emit the modified object when the save action completes.
-    @Output() onSave$ = new EventEmitter<IdlObject>();
+    @Output() recordSaved = new EventEmitter<IdlObject>();
 
     // Emit the original object when the save action is canceled.
-    @Output() onCancel$ = new EventEmitter<IdlObject>();
+    @Output() recordCanceled = new EventEmitter<IdlObject>();
 
     // Emit an error message when the save action fails.
-    @Output() onError$ = new EventEmitter<string>();
+    @Output() recordError = new EventEmitter<string>();
 
     @ViewChild('translator') private translator: TranslateComponent;
     @ViewChild('successStr') successStr: StringComponent;
@@ -149,18 +153,23 @@ export class FmRecordEditorComponent
     //       'view' for viewing an existing record without editing
     @Input() mode: 'create' | 'update' | 'view' = 'create';
 
-    // Record ID to view/update.  Value is dynamic.  Records are not
-    // fetched until .open() is called.
-    _recordId: any;
+    // recordId and record getters and setters.
+    // Note that setting the this.recordId to NULL does not clear the
+    // current value of this.record and vice versa.  Only viable data
+    // is actionable.  This allows the caller to use both @Input()'s
+    // without each clobbering the other.
+
+    // Record ID to view/update.  
+    _recordId: any = null;
     @Input() set recordId(id: any) {
         if (id) {
             if (id !== this._recordId) {
                 this._recordId = id;
+                this._record = null; // force re-fetch
                 this.handleRecordChange();
             }
         } else {
             this._recordId = null;
-            this._record = null;
         }
     }
 
@@ -169,16 +178,15 @@ export class FmRecordEditorComponent
     }
 
     // IDL record we are editing
-    _record: IdlObject;
-
+    _record: IdlObject = null;
     @Input() set record(r: IdlObject) {
         if (r) {
             if (!this.idl.pkeyMatches(this.record, r)) {
                 this._record = r;
+                this._recordId = null; // avoid mismatch
                 this.handleRecordChange();
             }
         } else {
-            this._recordId = null;
             this._record = null;
         }
     }
@@ -546,12 +554,12 @@ export class FmRecordEditorComponent
         this.convertDatatypesToIdl(recToSave);
         this.pcrud[this.mode]([recToSave]).toPromise().then(
             result => {
-                this.onSave$.emit(result);
+                this.recordSaved.emit(result);
                 this.successStr.current().then(msg => this.toast.success(msg));
                 if (this.isDialog()) { this.close(result); }
             },
             error => {
-                this.onError$.emit(error);
+                this.recordError.emit(error);
                 this.failStr.current().then(msg => this.toast.warning(msg));
                 if (this.isDialog()) { this.error(error); }
             }
@@ -559,7 +567,7 @@ export class FmRecordEditorComponent
     }
 
     cancel() {
-        this.onCancel$.emit(this.record);
+        this.recordCanceled.emit(this.record);
         this.close();
     }
 
-- 
2.11.0