From 26d660a8333cbcfb335ea0aa7013d4cdc9c77883 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 9 Mar 2021 17:09:18 -0500
Subject: [PATCH] LP1904036 Option to hide Holds grid popup dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../src/eg2/src/app/staff/circ/patron/holds.component.html    |  2 ++
 Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts  | 11 ++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/holds.component.html b/Open-ILS/src/eg2/src/app/staff/circ/patron/holds.component.html
index 13d5bd500b..df068e2b49 100644
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/holds.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/holds.component.html
@@ -9,6 +9,7 @@
         printTemplate="holds_for_patron"
         persistKey="circ.patron.holds"
         (placeHoldRequested)="newHold()"
+        [noLoadProgress]="true"
         [showPlaceHoldButton]="true"
         [hidePickupLibFilter]="true"
         [defaultSort]="[{name:'request_time',dir:'asc'}]"
@@ -22,6 +23,7 @@
       <eg-holds-grid 
         printTemplate="holds_for_patron"
         persistKey="circ.patron.holds.canceled"
+        [noLoadProgress]="true"
         [hidePickupLibFilter]="true"
         [showRecentlyCanceled]="true"
         [defaultSort]="[{name:'cancel_time',dir:'desc'}]"
diff --git a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
index a90d6e6ea4..65cad22a57 100644
--- a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
@@ -70,6 +70,10 @@ export class HoldsGridComponent implements OnInit {
     // Display bib record summary along the top of the detail page.
     @Input() showRecordSummary = false;
 
+    // If true, avoid popping up the progress dialog.  Note the grid
+    // has it's own generic embedded 'loading' progress indicator.
+    @Input() noLoadProgress = false;
+
     mode: 'list' | 'detail' | 'manage' = 'list';
     initDone = false;
     holdsCount: number;
@@ -357,8 +361,13 @@ export class HoldsGridComponent implements OnInit {
         let observer: Observer<any>;
         const observable = new Observable(obs => observer = obs);
 
-        this.progressDialog.open();
+        if (!this.noLoadProgress) {
+            // Note remaining dialog actions have no impact
+            this.progressDialog.open();
+        }
+
         this.progressDialog.update({value: 0, max: 1});
+
         let first = true;
         let loadCount = 0;
         this.net.request(
-- 
2.11.0