From 28c10007bb5fa54a262cfd221430557926d2a04e Mon Sep 17 00:00:00 2001 From: Lebbeous Fogle-Weekley Date: Mon, 15 Apr 2013 14:06:54 -0400 Subject: [PATCH] Acq: Be fuzzy about case when retrieving EDI documents The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among other things, try to avoid fetching the same EDI document multiple times when many rows in acq.edi_account refer to the same host and login credentials. Since in practice most vendors seem to run FTP servers for EDI on Windows, not UNIX, and pathnames are therefore case-insensitive, that test for other occurrences ought also to be case-insensitive. If I were to look at this as a purist, I could argue that vendor servers might sometimes by run on UNIX, and that for some reason it is possible that different vendor-to-buyer EDI documents (order responses or invoices) could have pathnames that differ only in the case of some characters. But that seems wildly unlikely. If anyone does take this possibility seriously, perhaps acq.edi_account needs a Boolean column to indicate the remote host's case [in]sensitivity. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Ben Shum --- Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm index a84b1c31b5..924787a702 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm @@ -135,7 +135,7 @@ sub retrieve_core { password => $account->password, in_dir => $account->in_dir }, - remote_file => $remote_file, + remote_file => {ilike => $remote_file}, status => {'in' => [qw/ processed /]}, }, { join => {"acqedi" => {}}, limit => 1 } -- 2.11.0