From 2c7ae4aba9d8e191f6c9ab764e997940b779b27d Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Wed, 11 Oct 2017 14:35:37 -0400
Subject: [PATCH] JBAS-1891 Remove 2.10-era hold copy count columns
 (LP#1402770)

This paritally reverts LP bug #1402770.

Avoid displaying or fetching data for the 2.10-era copy hold_count columns.
The data is unused locally and adds unnecessary API calls.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---
 Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2  |  1 -
 Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js |  2 +-
 Open-ILS/xul/staff_client/server/circ/util.js             | 11 -----------
 3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2
index 7f41136f76..2ce2a60d07 100644
--- a/Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2
+++ b/Open-ILS/src/templates/staff/circ/patron/t_items_out.tt2
@@ -97,7 +97,6 @@
     </a>
   </eg-grid-field>
   <eg-grid-field path="*" hidden></eg-grid-field>
-  <eg-grid-field path="target_copy.holds_count.count" hidden></eg-grid-field>
   <eg-grid-field label="[% l('Item Status') %]" path="target_copy.status.name" hidden></eg-grid-field>
   <eg-grid-field path="target_copy.circ_modifier" hidden></eg-grid-field>
   <eg-grid-field path="target_copy.*" hidden></eg-grid-field>
diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js b/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
index 110ead8585..979751491c 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
@@ -108,7 +108,7 @@ function($scope , $q , $routeParams , $timeout , egCore , egUser , patronSvc ,
             {   flesh : 4,
                 flesh_fields : {
                     circ : ['target_copy', 'workstation', 'checkin_workstation'],
-                    acp : ['call_number', 'holds_count', 'status', 'circ_lib', 'location', 'floating', 'age_protect'],
+                    acp : ['call_number', 'status', 'circ_lib', 'location', 'floating', 'age_protect'],
                     acn : ['record', 'owning_lib', 'prefix', 'suffix'],
                     bre : ['wide_display_entry']
                 },
diff --git a/Open-ILS/xul/staff_client/server/circ/util.js b/Open-ILS/xul/staff_client/server/circ/util.js
index 45de87c52d..72e4740c00 100644
--- a/Open-ILS/xul/staff_client/server/circ/util.js
+++ b/Open-ILS/xul/staff_client/server/circ/util.js
@@ -596,17 +596,6 @@ circ.util.columns = function(modify,params) {
                 }
             }
         },
-	{
-            'id' : 'ahhc',
-            'fm_class' : 'hasholdscount',
-            'label' : 'Holds Count',
-            'flex' : 1,
-            'primary' : false,
-            'hidden' : true,
-            'editable' : false, 'render' : function(my) {
-		return network.simple_request("FM_CIRC_HAS_HOLDS_COUNT_RETRIEVE_VIA_COPY",[ ses(), my.acp.id() ] );
-		}
-        },
         {
             'id' : 'prefix',
             'fm_class' : 'acn',
-- 
2.11.0