From 2f472bf946c652c27b5ea01696b7fc7ea4a222e0 Mon Sep 17 00:00:00 2001 From: Dan Briem Date: Fri, 17 Jun 2022 10:19:59 -0400 Subject: [PATCH] LP#1978839 Holds Pull List - Library Shortnames Display shortnames instead of IDs for the Requesting Library and Selection Library columns in the Pull List grid in the staff client. Test: 1. Circulation->Pull List for Hold Requests 2. Select OU with holds to pull or place an item hold on an available item and select the owning OU 3. Add the Requesting Library and Selection Library columns (note IDs are displayed) 5. Apply patch, rebuild Angular, rebuild Perl 6. Refresh and re-add columns (note shortnames are displayed) Signed-off-by: Dan Briem Signed-off-by: Galen Charlton --- Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html | 4 ++-- .../perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html index b6430cfac0..f3bad0b83c 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html +++ b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html @@ -221,10 +221,10 @@ - + - + diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index 284bf121d2..7f1d95c82e 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -2231,6 +2231,10 @@ SELECT h.id, h.request_time, h.capture_time, h.fulfillment_time, h.checkin_time pl.shortname AS pl_shortname, pl.name AS pl_name, pl.email AS pl_email, pl.phone AS pl_phone, pl.opac_visible AS pl_opac_visible, pl.fiscal_calendar AS pl_fiscal_calendar, + rl.shortname AS rl_shortname, + + sl.shortname AS sl_shortname, + tr.id AS tr_id, tr.source_send_time AS tr_source_send_time, tr.dest_recv_time AS tr_dest_recv_time, tr.target_copy AS tr_target_copy, tr.source AS tr_source, tr.dest AS tr_dest, tr.prev_hop AS tr_prev_hop, tr.copy_status AS tr_copy_status, tr.persistant_transfer AS tr_persistant_transfer, @@ -2376,6 +2380,8 @@ SELECT h.id, h.request_time, h.capture_time, h.fulfillment_time, h.checkin_time JOIN actor.usr ru ON (ru.id = h.requestor) JOIN actor.card ruc ON (ruc.id = ru.card) JOIN actor.org_unit pl ON (h.pickup_lib = pl.id) + JOIN actor.org_unit rl ON (h.request_lib = rl.id) + JOIN actor.org_unit sl ON (h.selection_ou = sl.id) JOIN t_field ON TRUE JOIN a_field ON TRUE JOIN s_field ON TRUE -- 2.11.0