From 34164eb6018773f08aa69438ab808df066bb0d5c Mon Sep 17 00:00:00 2001 From: miker Date: Fri, 12 Feb 2010 16:17:31 +0000 Subject: [PATCH] Addressing https://bugs.launchpad.net/evergreen/+bug/520632 -- not strictly required here, but for(;;) is better form for array access git-svn-id: svn://svn.open-ils.org/ILS/trunk@15517 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/web/js/dojo/fieldmapper/dojoData.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Open-ILS/web/js/dojo/fieldmapper/dojoData.js b/Open-ILS/web/js/dojo/fieldmapper/dojoData.js index 597e9b127e..a2993ed7bf 100644 --- a/Open-ILS/web/js/dojo/fieldmapper/dojoData.js +++ b/Open-ILS/web/js/dojo/fieldmapper/dojoData.js @@ -26,10 +26,10 @@ if(!dojo._hasResource['fieldmapper.dojoData']){ function _fromStoreItem (data) { this.fromHash(data); - for (var i in this._ignore_fields) + for (var i = 0; i < this._ignore_fields.length; i++) this[this._ignore_fields[i]](null); - for ( var i=0; i < this._fields.length; i++) { + for (var i = 0; i < this._fields.length; i++) { if (dojo.isArray( this[this._fields[i]]() )) this[this._fields[i]]( this[this._fields[i]]()[0] ); } @@ -53,22 +53,22 @@ if(!dojo._hasResource['fieldmapper.dojoData']){ if (!params) params = {}; var data = this.initStoreData(label, params); - for (var i in list) data.items.push( list[i].toHash(true, params.virtualFields) ); + for (var i = 0; i < list.length; i++) data.items.push( list[i].toHash(true, params.virtualFields) ); if (params.children && params.parent) { var _hash_list = data.items; var _find_root = {}; - for (var i in _hash_list) { + for (var i = 0; i < _hash_list.length; i++) { _find_root[_hash_list[i][params.identifier]] = _hash_list[i]; } var item_data = []; - for (var i in _hash_list) { + for (var i = 0; i < _hash_list.length; i++) { var obj = _hash_list[i] obj[params.children] = []; - for (var j in _hash_list) { + for (var j = 0; j < _hash_list.length; j++) { var kid = _hash_list[j]; if (kid[params.parent] == obj[params.identifier]) { obj[params.children].push( { _reference : kid[params.identifier] } ); @@ -80,7 +80,7 @@ if(!dojo._hasResource['fieldmapper.dojoData']){ item_data.push( obj ); } - for (var j in _find_root) { + for (var j = 0; j < _find_root.length; j++) { _find_root[j]['_top'] = 'true'; if (!_find_root[j][params.parent]) _find_root[j]['_trueRoot'] = 'true'; -- 2.11.0