From 38bafbad2b7ed42934ee9e51a03c0beacb95b63e Mon Sep 17 00:00:00 2001 From: Mike Rylander Date: Fri, 17 Jan 2014 17:32:01 -0500 Subject: [PATCH] Fix constructed method call syntax and a logic inversion Signed-off-by: Mike Rylander --- .../lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm index 074d3090ca..997c94f1b6 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm @@ -711,8 +711,8 @@ sub dynamic_filter_compile { $_dfilter_controlled_cache{$filter}{controlled} = scalar @$ccvm_list; } - my $method = 'search_' . $_dfilter_controlled_cache{$filter}{controlled} ? - 'config_coded_value_map' : 'metabib_uncontrolled_record_attr_value'; + my $method = $_dfilter_controlled_cache{$filter}{controlled} ? + 'search_config_coded_value_map' : 'search_metabib_uncontrolled_record_attr_value'; my $match_field = $_dfilter_controlled_cache{$filter}{controlled} ? 'ctype' : 'attr'; @@ -722,9 +722,7 @@ sub dynamic_filter_compile { map { $_->id } @{ - OpenILS::Utils::CStoreEditor - ->new - ->$method({ $match_field => $filter, value => $params }) + $e->$method({ $match_field => $filter, code => $params }) } ) ); @@ -1073,7 +1071,7 @@ sub flatten { my $vlist_query = $self->dynamic_filter_compile( $fname, $filter->args, $filter->negate ); # bool joiner for intra-plan nodes/filters - push(@dlist, $self->joiner) if !@dlist; + push(@dlist, $self->joiner) if @dlist; push(@dlist, $vlist_query); $uses_mrv = 1; } else { -- 2.11.0