From 3f762988042021aaa31a646759055f226d58e777 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 15 May 2018 16:12:12 -0400
Subject: [PATCH] LP#1771422 Reset transiting hold copy status fix
Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit. Let the
transit API handle the status instead.
This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 350fde2229..b15de7cf58 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -1978,8 +1978,6 @@ sub _reset_hold {
} elsif( $copy->status == OILS_COPY_STATUS_IN_TRANSIT ) {
- # We don't want the copy to remain "in transit"
- $copy->status(OILS_COPY_STATUS_RESHELVING);
$logger->warn("! reseting hold [$hid] that is in transit");
my $transid = $e->search_action_hold_transit_copy({hold=>$hold->id,cancel_time=>undef},{idlist=>1})->[0];
--
2.11.0