From 43119f3162bf0ef87a3c220e4876468b29bc49e6 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 29 Jun 2021 11:42:40 -0400
Subject: [PATCH] LP1904036 Grid auto columns label/etc fixes

* Ensure the datatype is propagated to auto columns.
* Display 'class: fieldname' in the column picker, but only display
  field name in the grid header to avoid large column names.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---
 Open-ILS/src/eg2/src/app/share/grid/grid-column.component.ts   | 1 +
 Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html | 4 ++--
 Open-ILS/src/eg2/src/app/share/grid/grid.ts                    | 7 +++++++
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid-column.component.ts b/Open-ILS/src/eg2/src/app/share/grid/grid-column.component.ts
index 77856e0eb8..586cef66b3 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid-column.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid-column.component.ts
@@ -87,6 +87,7 @@ export class GridColumnComponent implements OnInit {
         col.timezoneContextOrg = this.timezoneContextOrg;
         col.idlClass = this.idlClass;
         col.isAuto = false;
+
         this.grid.context.columnSet.add(col);
 
         if (this.cellTemplate &&
diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html b/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
index a68076514c..a3d0a6b138 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
@@ -28,13 +28,13 @@
     class="eg-grid-cell eg-grid-header-cell" [ngStyle]="{flex:col.flex}">
     <a class="sortable label-with-material-icon" *ngIf="col.isSortable"
       (click)="sortOneColumn(col)">
-      <span class="eg-grid-header-cell-sort-label">{{col.label}}</span>
+      <span class="eg-grid-header-cell-sort-label">{{col.headerLabel}}</span>
       <span class="material-icons eg-grid-header-cell-sort-arrow"
         *ngIf="isColumnSorting(col, 'ASC')">arrow_upwards</span>
       <span class="material-icons eg-grid-header-cell-sort-arrow"
         *ngIf="isColumnSorting(col, 'DESC')">arrow_downwards</span>
     </a>
-    <span *ngIf="!col.isSortable">{{col.label}}</span>
+    <span *ngIf="!col.isSortable">{{col.headerLabel}}</span>
   </div>
 </div>
 <div *ngIf="context.isFilterable"
diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid.ts b/Open-ILS/src/eg2/src/app/share/grid/grid.ts
index adfd8f7291..0bc1f1dba7 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid.ts
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid.ts
@@ -16,6 +16,7 @@ export class GridColumn {
     name: string;
     path: string;
     label: string;
+    headerLabel: string;
     flex: number;
     align: string;
     hidden: boolean;
@@ -205,6 +206,11 @@ export class GridColumnSet {
             newCol.isAuto = true;
             newCol.path = dotpath ? dotpath + '.' + field.name : field.name;
             newCol.label = dotpath ? classObj.label + ': ' + field.label : field.label;
+            newCol.datatype = field.datatype;
+
+            // Avoid including the class label prefix in the main grid
+            // header display so it doesn't take up so much horizontal space.
+            newCol.headerLabel = field.label;
 
             this.add(newCol);
         });
@@ -346,6 +352,7 @@ export class GridColumnSet {
         if (!col.align) { col.align = 'left'; }
         if (!col.label) { col.label = col.name; }
         if (!col.datatype) { col.datatype = 'text'; }
+        if (!col.isAuto) { col.headerLabel = col.label; }
 
         col.visible = !col.hidden;
     }
-- 
2.11.0