From 43a2d1465e6ae1f8fbd2a8873d602e6b55700f51 Mon Sep 17 00:00:00 2001
From: Dan Scott <dscott@laurentian.ca>
Date: Sun, 11 Dec 2011 23:37:02 -0500
Subject: [PATCH] TPAC: Record details - inline style to classes

Continue the march towards no inline styles in the record details page.
Includes a small tweak for electronic resource display so that the
unordered list gains a bit of space on the left-hand side from the image
location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
---
 .../src/templates/opac/parts/record/summary.tt2    | 20 ++++-----
 Open-ILS/src/templates/opac/parts/result/table.tt2 |  2 +-
 Open-ILS/web/css/skin/default/opac/style.css       | 48 +++++++++++++++++++---
 3 files changed, 53 insertions(+), 17 deletions(-)

diff --git a/Open-ILS/src/templates/opac/parts/record/summary.tt2 b/Open-ILS/src/templates/opac/parts/record/summary.tt2
index 595978f37b..540c30d8cf 100644
--- a/Open-ILS/src/templates/opac/parts/record/summary.tt2
+++ b/Open-ILS/src/templates/opac/parts/record/summary.tt2
@@ -9,10 +9,10 @@
     [% INCLUDE 'opac/parts/record/refworks.tt2' %]
 [%- END %]
 
-<hr style="margin-top: 1em;" />
+<hr />
 
 [%- # This holds the record summary information %]
-<div id="rdetail_image_div" style="float: left; margin-right: 1em;">
+<div id="rdetail_image_div">
     [% ident = attrs.isbn_clean || attrs.upc; IF ident; %]
     <a href='[% ctx.media_prefix %]/opac/extras/ac/jacket/large/[% ident | uri %]'><img
         alt="[% l('Image of item') %]" id='rdetail_image'
@@ -21,14 +21,14 @@
     <br />
 </div>
  
-<div id="rdetail_actions_div" style="float: right; margin-left: 1em;">
-    <div class="rdetail_aux_utils opac-auto-010">
+<div id="rdetail_actions_div">
+    <div class="rdetail_aux_utils place_hold">
         <a href="[% mkurl(ctx.opac_root _ '/place_hold', 
             {hold_target => ctx.bre_id, hold_type => 'T', hold_source_page => mkurl()}) %]" 
         class="no-dec"><img src="[% ctx.media_prefix %]/images/green_check.png" alt="[% l('place hold') %]" /><span 
-        style="position:relative;top:-3px;left:3px;">[% l('Place Hold') %]</span></a>
+        class="place_hold">[% l('Place Hold') %]</span></a>
     </div>
-    <div class="rdetail_aux_utils opac-auto-121">
+    <div class="rdetail_aux_utils toggle_list">
     [%-  
         operation = ctx.mylist.grep(ctx.bre_id).size ? "delete" : "add";
         label = (operation == "add") ? l("Add to my list") : l("Remove from my list"); 
@@ -42,7 +42,7 @@
 
 <div id='rdetail_title_div'>
     [%- IF attrs.format_icon %]
-    <div style="float:right;margin-right:17px;">
+    <div class="format_icon">
         <img alt="[% attrs.format_label %]" title="[% attrs.format_label | html %]" src="[% attrs.format_icon %]" />
     </div>
     [%- END %]
@@ -77,7 +77,7 @@
 num_uris = merged_uris.size;
 IF num_uris > 0;
 -%]
-<h2 style="margin-top: 1em;">[% l("Electronic resources") %]</h2>
+<h2 class="rdetail_uris">[% l("Electronic resources") %]</h2>
 <div class="rdetail_uris">
     [%- IF num_uris > 1 %]<ul>[% END %]
     [%- FOR uri IN merged_uris %]
@@ -189,12 +189,12 @@ IF num_uris > 0;
             <td>
                 [%- more_copies_limit = 50 %] [%# TODO: config %]
                 [%- IF  ctx.copy_limit != more_copies_limit AND ctx.copies.size >= ctx.copy_limit %]
-                    <div style='margin-top:10px;'>
+                    <div class="rdetail_show_copies">
                         <img src="[% ctx.media_prefix %]/images/plus_sign.png" />
                         <a href="[% mkurl('', {copy_limit => more_copies_limit, copy_offset => 0}) %]">[% l('Show more copies') %]</a>
                     </div>
                 [%- ELSIF ctx.copy_limit == more_copies_limit %]
-                    <div style='margin-top:10px;'>
+                    <div  class="rdetail_show_copies">
                         <img src="[% ctx.media_prefix %]/images/minus_sign.png" />
                         <a href="[% mkurl('', {copy_limit => 0, copy_offset => 0}) %]">[% l('Show fewer copies') %]</a>
                     </div>
diff --git a/Open-ILS/src/templates/opac/parts/result/table.tt2 b/Open-ILS/src/templates/opac/parts/result/table.tt2
index 46790fca85..fe3865a6b4 100644
--- a/Open-ILS/src/templates/opac/parts/result/table.tt2
+++ b/Open-ILS/src/templates/opac/parts/result/table.tt2
@@ -204,7 +204,7 @@
                                             <td nowrap='nowrap' width="1" align="right">
                                                 <div style="width:250px;text-align:left;">
                                                     <div style="float:right;">
-                                                        <div class="results_aux_utils opac-auto-010"><a
+                                                        <div class="results_aux_utils place_hold"><a
                                                                 href="[% mkurl(ctx.opac_root _ '/place_hold', 
                                                                     {hold_target => rec.id, hold_type => 'T', hold_source_page => mkurl()}) %]" 
                                                                     name="place_hold_link" class="no-dec"><img
diff --git a/Open-ILS/web/css/skin/default/opac/style.css b/Open-ILS/web/css/skin/default/opac/style.css
index ffd92ec570..39afdff85f 100644
--- a/Open-ILS/web/css/skin/default/opac/style.css
+++ b/Open-ILS/web/css/skin/default/opac/style.css
@@ -349,8 +349,30 @@ span.dash_divider {
 	padding-right: 10px;
 }
 
-.rdetail_uris {
-    padding: 1em;
+h2.rdetail_uris {
+    margin-top: 1em;
+}
+div.rdetail_uris {
+    padding: 0.5em 1em 0.5em 1em;
+    background-color: lightGray;
+}
+div.rdetail_uris ul li {
+    position: relative;
+    left: 1em;
+}
+
+div.rdetail_show_copies {
+    margin-top: 1em;
+}
+
+#rdetail_image_div {
+    float: left;
+    margin-right: 1em;
+}
+
+#rdetail_image_div {
+    float: right;
+    margin-left: 1em;
 }
 
 .rdetail_aux_utils {
@@ -360,6 +382,24 @@ span.dash_divider {
 	padding-right: 70px;
 }
 
+div.place_hold {
+    border-bottom: 1px dotted #ccc;
+    padding-top: 10px;
+}
+
+span.place_hold {
+    position:relative;
+    top:-3px;
+    left:3px;
+}
+
+div.toggle_list { padding-top: 6px; }
+
+div.format_icon {
+    float: right;
+    margin-right: 17px;
+}
+
 .results_aux_utils {
 	border-left:1px dotted #ccc;
 	padding-left: 17px;
@@ -1213,10 +1253,6 @@ table.bookbag-specific {
 .save-notes { padding-bottom: 1.5ex; }
 
 /* Moved from semiauto.css */
-.opac-auto-010 {
-    border-bottom: 1px dotted #ccc;
-    padding-top: 10px;
-}
 .opac-auto-011 {
     border-bottom: 1px dotted #ccc;
     padding-top: 6px;
-- 
2.11.0