From 46ebe4eebe23f560caba64e524af59a3248896e8 Mon Sep 17 00:00:00 2001
From: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Date: Wed, 11 Jan 2023 15:21:21 -0600
Subject: [PATCH] WIP Remove input placeholders in fm-editor

Removes the input placeholders in fm-editor. They are identical to the
form labels, and their presence makes users think that the field has
already been filled in.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
---
 .../app/share/fm-editor/fm-editor.component.html   | 24 ++++++++++------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
index 518125ccaa..4006f7da96 100644
--- a/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
+++ b/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
@@ -30,10 +30,12 @@
       <div class="form-group row" *ngFor="let field of fields">
         <div class="col-lg-3">
           <label for="{{idPrefix}}-{{field.name}}">{{field.label}}</label>
-          <eg-help-popover [placement]="'right'" *ngIf="field.helpText" helpText="{{field.helpTextValue}}"></eg-help-popover>
         </div>
         <div class="col-lg-9">
-
+          <ng-container *ngIf="field.helpText">
+            <p class="form-text">{{field.helpTextValue}}</p>
+          </ng-container>
+        
           <ng-container [ngSwitch]="inputType(field)">
 
             <ng-container *ngSwitchCase="'template'">
@@ -79,8 +81,7 @@
 
             <ng-container *ngSwitchCase="'org_unit'">
               <eg-org-select
-                placeholder="{{field.label}}..."
-                i18n-placeholder
+                placeholder=""
                 domId="{{idPrefix}}-{{field.name}}"
                 [limitPerms]="modePerms[mode]"
                 [readOnly]="field.readOnly"
@@ -96,8 +97,7 @@
                 type="number" step="0.1"
                 name="{{field.name}}"
                 id="{{idPrefix}}-{{field.name}}"
-                placeholder="{{field.label}}..."
-                i18n-placeholder
+                placeholder=""
                 [readonly]="field.readOnly"
                 [required]="field.isRequired()"
                 [ngModel]="record[field.name]()"
@@ -110,8 +110,7 @@
                 type="number"
                 name="{{field.name}}"
                 id="{{idPrefix}}-{{field.name}}"
-                placeholder="{{field.label}}..."
-                i18n-placeholder
+                placeholder=""
                 [required]="field.isRequired()"
                 egMin="{{field.min}}"
                 egMax="{{field.max}}"
@@ -125,8 +124,7 @@
                 type="number" step="0.1"
                 name="{{field.name}}"
                 id="{{idPrefix}}-{{field.name}}"
-                placeholder="{{field.label}}..."
-                i18n-placeholder
+                placeholder=""
                 [required]="field.isRequired()"
                 [ngModel]="record[field.name]()"
                 (ngModelChange)="record[field.name]($event)"/>
@@ -137,7 +135,7 @@
                 class="form-control"
                 id="{{idPrefix}}-{{field.name}}" name="{{field.name}}"
                 type="text" pattern="[\s\S]*\S[\s\S]*"
-                placeholder="{{field.label}}..." i18n-placeholder
+                placeholder=""
                 [required]="field.isRequired()"
                 [ngModel]="record[field.name]()"
                 (ngModelChange)="record[field.name]($event)"/>
@@ -164,7 +162,7 @@
             <ng-container *ngSwitchCase="'link'">
               <eg-combobox
                 id="{{idPrefix}}-{{field.name}}" name="{{field.name}}"
-                placeholder="{{field.label}}..." i18n-placeholder 
+                placeholder=""
                 [required]="field.isRequired()"
                 [idlClass]="field.class" [asyncSupportsEmptyTermClick]="true"
                 [idlBaseQuery]="field.idlBaseQuery"
@@ -177,7 +175,7 @@
             <ng-container *ngSwitchCase="'list'">
               <eg-combobox
                 domId="{{idPrefix}}-{{field.name}}" name="{{field.name}}"
-                placeholder="{{field.label}}..." i18n-placeholder 
+                placeholder=""
                 [required]="field.isRequired()"
                 [entries]="field.linkedValues"
                 [asyncDataSource]="field.linkedValuesSource"
-- 
2.11.0