From 475a1e60f249b07e7a6ad7d3e66554a34ec21be4 Mon Sep 17 00:00:00 2001 From: Mike Rylander Date: Fri, 14 Aug 2020 15:35:10 -0400 Subject: [PATCH] LP#1858114: Fix thinko in template-parameter collection Minor thinko in the use of Array.prototype.concat() when gathering the "where" and "having" template parameters -- concat() does not alter the array it is called on, so we need to assign the result back to the array. Signed-off-by: Mike Rylander Signed-off-by: Angela Kilsdonk Signed-off-by: Jason Boyer --- Open-ILS/web/reports/oils_rpt.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/web/reports/oils_rpt.js b/Open-ILS/web/reports/oils_rpt.js index 3a755527b1..822217ad8a 100644 --- a/Open-ILS/web/reports/oils_rpt.js +++ b/Open-ILS/web/reports/oils_rpt.js @@ -154,7 +154,7 @@ oilsReport.prototype._gatherParams = function(params, arr, type, field) { oilsReport.prototype.gatherTemplateParams = function() { var arr = this.__gatherTemplateParams(this.def.where, 'where'); - arr.concat(this.__gatherTemplateParams(this.def.having, 'having')); + arr = arr.concat(this.__gatherTemplateParams(this.def.having, 'having')); _debug("template params: " + js2JSON(arr)); return arr; } -- 2.11.0