From 4e5883264d5e8c64010845fa7058d9d41501293e Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@equinoxOLI.org>
Date: Thu, 9 Dec 2021 15:45:17 -0500
Subject: [PATCH] LP#1942220: change text from "lineitem" to "line item"

"lineitem" and its variants much more commonly split into
two words for human-readable text

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../acq/lineitem/add-copies-dialog.component.html  |  2 +-
 .../acq/lineitem/cancel-dialog.component.html      |  6 ++---
 .../lineitem/claim-policy-dialog.component.html    |  2 +-
 .../delete-lineitems-dialog.component.html         | 10 ++++----
 .../app/staff/acq/lineitem/detail.component.html   |  2 +-
 .../export-attributes-dialog.component.html        |  2 +-
 .../acq/lineitem/lineitem-list.component.html      | 30 +++++++++++-----------
 .../lineitem/link-invoice-dialog.component.html    |  2 +-
 .../eg2/src/app/staff/acq/po/create.component.html |  2 +-
 .../src/app/staff/acq/po/summary.component.html    |  8 +++---
 10 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/add-copies-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/add-copies-dialog.component.html
index c55f8427e1..29d1b3eed1 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/add-copies-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/add-copies-dialog.component.html
@@ -8,7 +8,7 @@
       </button>
     </div>
     <div class="modal-body">
-      <h4 i18n>Lineitem(s) selected:
+      <h4 i18n>Line Item(s) selected:
         <span *ngFor="let id of ids; last as isLast">
           {{id}}<span *ngIf="!isLast">,</span>
         </span>
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/cancel-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/cancel-dialog.component.html
index 114bea6884..a8e7dd1a6a 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/cancel-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/cancel-dialog.component.html
@@ -2,7 +2,7 @@
   <form class="form-validated">
     <div class="modal-header bg-info">
       <h3 class="modal-title" *ngIf="recordType === 'po'" i18n>Confirm Order Cancellation</h3>
-      <h3 class="modal-title" *ngIf="recordType === 'li'" i18n>Confirm Lineitem Cancellation</h3>
+      <h3 class="modal-title" *ngIf="recordType === 'li'" i18n>Confirm Line Item Cancellation</h3>
       <h3 class="modal-title" *ngIf="recordType === 'lid'" i18n>Confirm Item Cancellation</h3>
       <button type="button" class="close"
         i18n-aria-label aria-label="Close" (click)="close()">
@@ -12,8 +12,8 @@
     <div class="modal-body">
       <h4 *ngIf="recordType === 'po'" i18n>Please select a cancel reason and click "Apply" to cancel the order,
         or "Exit Dialog" to exit without cancelling the order.</h4>
-      <h4 *ngIf="recordType === 'li'" i18n>Please select a cancel reason and click "Apply" to cancel the lineitem,
-        or "Exit Dialog" to exit without cancelling the lineitem.</h4>
+      <h4 *ngIf="recordType === 'li'" i18n>Please select a cancel reason and click "Apply" to cancel the line item,
+        or "Exit Dialog" to exit without cancelling the line item.</h4>
       <h4 *ngIf="recordType === 'lid'" i18n>Please select a cancel reason and click "Apply" to cancel the item,
         or "Exit Dialog" to exit without cancelling the item.</h4>
       <eg-combobox domId="acq-cancel-dialog" name="acq-cancel-dialog" 
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/claim-policy-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/claim-policy-dialog.component.html
index 37b599e2db..c295f329df 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/claim-policy-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/claim-policy-dialog.component.html
@@ -8,7 +8,7 @@
       </button>
     </div>
     <div class="modal-body">
-      <h4 i18n>Lineitem(s) selected:
+      <h4 i18n>Line Item(s) selected:
         <span *ngFor="let id of ids; last as isLast">
           {{id}}<span *ngIf="!isLast">,</span>
         </span>
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/delete-lineitems-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/delete-lineitems-dialog.component.html
index c819dc0b59..6b7e645049 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/delete-lineitems-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/delete-lineitems-dialog.component.html
@@ -1,21 +1,21 @@
 <ng-template #dialogContent>
   <form class="form-validated">
     <div class="modal-header bg-info">
-      <h3 class="modal-title" i18n>Confirm Deletion of Lineitems</h3>
+      <h3 class="modal-title" i18n>Confirm Deletion of Line Items</h3>
       <button type="button" class="close"
         i18n-aria-label aria-label="Close" (click)="close()">
         <span aria-hidden="true">&times;</span>
       </button>
     </div>
     <div class="modal-body">
-      <h4 i18n>Lineitem(s) selected:
+      <h4 i18n>Line Item(s) selected:
         <span *ngFor="let id of ids; last as isLast">
           {{id}}<span *ngIf="!isLast">,</span>
         </span>
       </h4>
-      <h4 i18n>Are you sure you want to delete the selected lineitems?</h4>
-      <h4 i18n>Please click "Apply" to delete lineitems or "Exit Dialog"
-               to exit without deleting lineitems.</h4>
+      <h4 i18n>Are you sure you want to delete the selected line items?</h4>
+      <h4 i18n>Please click "Apply" to delete line items or "Exit Dialog"
+               to exit without deleting line items.</h4>
     </div>
     <div class="modal-footer">
       <button type="button" class="btn btn-success"
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/detail.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/detail.component.html
index 5bcba98f0d..386dfc160a 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/detail.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/detail.component.html
@@ -31,7 +31,7 @@
       <ng-container *ngIf="lineitem">
         <div class="mt-3">
           <div *ngIf="lineitem.eg_bib_id()" class="alert alert-warning" i18n>
-            Changes to lineitems that are linked to catalog records will
+            Changes to line items that are linked to catalog records will
             not result in changes to the cataloged record.
           </div>
           <eg-marc-editor [recordXml]="lineitem.marc()" [inPlaceMode]="true"
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/export-attributes-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/export-attributes-dialog.component.html
index 6ffb3dd59e..3fa1f65862 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/export-attributes-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/export-attributes-dialog.component.html
@@ -8,7 +8,7 @@
       </button>
     </div>
     <div class="modal-body">
-      <h4 i18n>Lineitem(s) selected:
+      <h4 i18n>Line Item(s) selected:
         <span *ngFor="let id of ids; last as isLast">
           {{id}}<span *ngIf="!isLast">,</span>
         </span>
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
index 8192118bb3..842ef41129 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
@@ -20,34 +20,34 @@
         <a ngbDropdownItem routerLink="../brief-record"
           queryParamsHandling="merge" i18n>Add Brief Record</a>
         <button ngbDropdownItem (click)="deleteLineitems()" 
-          [disabled]="!canDeleteLis() || !selectedIds().length" i18n>Delete Selected Lineitems</button>
+          [disabled]="!canDeleteLis() || !selectedIds().length" i18n>Delete Selected Line Items</button>
         <button ngbDropdownItem (click)="addCopiesToLineitems()" 
-          [disabled]="isActivatedPo() || !selectedIds().length" i18n>Add Items to Selected Lineitems</button>
+          [disabled]="isActivatedPo() || !selectedIds().length" i18n>Add Items to Selected Line Items</button>
         <button ngbDropdownItem (click)="exportSingleAttributeList()" 
-          [disabled]="!selectedIds().length" i18n>Export Single Attribute List for Selected Lineitems</button>
+          [disabled]="!selectedIds().length" i18n>Export Single Attribute List for Selected Line Items</button>
         <div class="dropdown-divider"></div>
         <h6 class="dropdown-header" i18n>Selection List Actions</h6>
         <button ngbDropdownItem (click)="createPo()" 
-          [disabled]="!picklistId" i18n>Create Purchase Order from Selected Lineitems</button>
+          [disabled]="!picklistId" i18n>Create Purchase Order from Selected Line Items</button>
         <button ngbDropdownItem (click)="createPo(true)"
-          [disabled]="!picklistId" i18n>Create Purchase Order from All Lineitems</button>
+          [disabled]="!picklistId" i18n>Create Purchase Order from All Line Items</button>
         <div class="dropdown-divider"></div>
         <h6 class="dropdown-header" i18n>Purchase Order Actions</h6>
         <a ngbDropdownItem routerLink="../create-assets"
           [disabled]="!isPendingPo()"
           queryParamsHandling="merge" i18n>Load Bibs and Items</a>
         <button ngbDropdownItem (click)="receiveSelected()" 
-          [disabled]="!poId" i18n>Mark Selected Lineitems as Received</button>
+          [disabled]="!poId" i18n>Mark Selected Line Items as Received</button>
         <button ngbDropdownItem (click)="unReceiveSelected()" 
-          [disabled]="!poId" i18n>Un-Receive Selected Lineitems</button>
+          [disabled]="!poId" i18n>Un-Receive Selected Line Items</button>
         <button ngbDropdownItem (click)="cancelSelected()" 
-          [disabled]="!poId" i18n>Cancel Selected Lineitems</button>
+          [disabled]="!poId" i18n>Cancel Selected Line Items</button>
         <button ngbDropdownItem (click)="applyClaimPolicyToSelected()" 
-          [disabled]="!poId || !selectedIds().length" i18n>Apply Claim Policy to Selected Lineitems</button>
+          [disabled]="!poId || !selectedIds().length" i18n>Apply Claim Policy to Selected Line Items</button>
         <button ngbDropdownItem (click)="createInvoiceFromSelected()" 
-          [disabled]="!isActivatedPo() || !selectedIds().length" i18n>Create Invoice from Selected Lineitems</button>
+          [disabled]="!isActivatedPo() || !selectedIds().length" i18n>Create Invoice from Selected Line Items</button>
         <button ngbDropdownItem (click)="linkInvoiceFromSelected()" 
-          [disabled]="!isActivatedPo() || !selectedIds().length" i18n>Link Selected Lineitems to Invoice</button>
+          [disabled]="!isActivatedPo() || !selectedIds().length" i18n>Link Selected Line Items to Invoice</button>
       </div>
     </div>
   </div>
@@ -167,7 +167,7 @@
             [ngModel]="filterField" (ngModelChange)="filterFieldChange($event)"
             class="form-control">
             <option value="" i18n></option>
-            <option value="id" i18n>Lineitem ID</option>
+            <option value="id" i18n>Line Item ID</option>
             <option value="state" i18n>Status</option>
             <option value="acqlia:title" i18n>Title</option>
             <option value="acqlia:author" i18n>Author</option>
@@ -224,8 +224,8 @@
           <select name="sort-order-select" id="sort-order-select"
             [ngModel]="sortOrder" (ngModelChange)="sortOrderChange($event)"
             class="form-control">
-            <option value="li_id_asc" i18n>Lineitem ID Ascending</option>
-            <option value="li_id_desc" i18n>Lineitem ID Descending</option>
+            <option value="li_id_asc" i18n>Line Item ID Ascending</option>
+            <option value="li_id_desc" i18n>Line Item ID Descending</option>
             <option value="title_asc" i18n>Title Ascending</option>
             <option value="title_desc" i18n>Title Descending</option>
             <option value="author_asc" i18n>Author Ascending</option>
@@ -292,7 +292,7 @@
         </div>
         <div class="row">
           <div class="col-lg-12">
-            <span title="Lineitem ID" i18n-title i18n># {{li.id()}}</span>
+            <span title="Line Item ID" i18n-title i18n># {{li.id()}}</span>
             <span class="ml-1 mr-1" i18n> | </span>
             <span title="Existing Item Count" i18n-title i18n
               [ngClass]="{'text-danger font-weight-bold': existingCopyCounts[li.id()] > 0}">
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/link-invoice-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/link-invoice-dialog.component.html
index aa736ba5be..c73b412a39 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/link-invoice-dialog.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/link-invoice-dialog.component.html
@@ -8,7 +8,7 @@
       </button>
     </div>
     <div class="modal-body">
-      <h4 i18n *ngIf="liIds && liIds.length">Lineitem(s) selected:
+      <h4 i18n *ngIf="liIds && liIds.length">Line Item(s) selected:
         <span *ngFor="let id of liIds; last as isLast">
           {{id}}<span *ngIf="!isLast">,</span>
         </span>
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html b/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
index a094da60c2..79b4826d99 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
@@ -3,7 +3,7 @@
 
 <div class="col-lg-4 offset-lg-4">
   <div *ngIf="lineitems.length">
-    <span i18n>Creating for {{lineitems.length}} lineitems.</span>
+    <span i18n>Creating for {{lineitems.length}} line items.</span>
     <hr class="p-1" />
   </div>
   <div class="form-group">
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/po/summary.component.html b/Open-ILS/src/eg2/src/app/staff/acq/po/summary.component.html
index 14c44b5792..7555120345 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/po/summary.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/po/summary.component.html
@@ -61,13 +61,13 @@
               <ng-template #noPrice>
                 <ng-container 
                   *ngIf="evt.textcode == 'ACQ_LINEITEM_NO_PRICE'; else noCopies">
-                  <span i18n>One or more lineitems have no price.</span>
+                  <span i18n>One or more line items have no price.</span>
                 </ng-container>
               </ng-template>
               <ng-template #noCopies>
                 <ng-container 
                   *ngIf="evt.textcode == 'ACQ_LINEITEM_NO_COPIES'; else noOwner">
-                  <span i18n>One or more lineitems have no items attached.</span>
+                  <span i18n>One or more line items have no items attached.</span>
                 </ng-container>
               </ng-template>
               <ng-template #noOwner>
@@ -123,7 +123,7 @@
 
       <div class="row">
         <div class="col-lg-4 d-flex">
-          <div class="flex-2" i18n>Lineitems:</div>
+          <div class="flex-2" i18n>Line Items:</div>
           <div class="flex-4">{{po().lineitem_count()}}</div>
         </div>
         <div class="col-lg-8 d-flex">
@@ -131,7 +131,7 @@
             <input class="ml-0 form-check-input" type="checkbox" (change)="setCanActivate()"
               id="zero-copy-cbox" [(ngModel)]="zeroCopyActivate"/>
             <label class="form-check-label" for="zero-copy-cbox" i18n>
-              Allow Activation with Zero-Item Lineitems?
+              Allow Activation with Zero-Item Line Items?
             </label>
           </div>
         </div>
-- 
2.11.0