From 584d3f5c6c79bf159a13e5697acb4fa565f1ad08 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Thu, 6 Oct 2022 13:14:07 -0400 Subject: [PATCH] Revert "LP1904036 Ang Patron UI updating non-menu links" This reverts commit 26fe8cf5bb70f26138a740962dc3d8e2eb028bd2. Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton --- .../src/eg2/src/app/staff/booking/reservations-grid.component.ts | 8 +------- Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html | 2 +- .../src/eg2/src/app/staff/catalog/result/record.component.html | 4 ++-- .../app/staff/share/holdings/mark-damaged-dialog.component.html | 2 +- Open-ILS/src/eg2/src/app/staff/share/holds/detail.component.html | 4 ++-- Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html | 2 +- Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts | 8 +++----- .../src/templates/staff/admin/local/circ/neg_balance_users.tt2 | 2 +- Open-ILS/src/templates/staff/cat/bucket/batch_hold/t_pending.tt2 | 2 +- Open-ILS/src/templates/staff/cat/bucket/batch_hold/t_view.tt2 | 2 +- Open-ILS/src/templates/staff/cat/bucket/share/t_bucket_info.tt2 | 2 +- Open-ILS/src/templates/staff/cat/item/t_circ_list_pane.tt2 | 6 +++--- Open-ILS/src/templates/staff/cat/item/t_circs_pane.tt2 | 8 ++++---- Open-ILS/src/templates/staff/cat/item/t_holds_pane.tt2 | 8 ++++---- Open-ILS/src/templates/staff/cat/item/t_list.tt2 | 2 +- Open-ILS/src/templates/staff/circ/checkin/t_checkin.tt2 | 2 +- Open-ILS/src/templates/staff/circ/curbside/t_arrived_manager.tt2 | 2 +- .../src/templates/staff/circ/curbside/t_delivered_manager.tt2 | 2 +- Open-ILS/src/templates/staff/circ/curbside/t_staged_manager.tt2 | 2 +- .../src/templates/staff/circ/curbside/t_to_be_staged_manager.tt2 | 2 +- Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2 | 2 +- Open-ILS/src/templates/staff/circ/patron/bucket/t_pending.tt2 | 2 +- Open-ILS/src/templates/staff/circ/patron/bucket/t_view.tt2 | 2 +- .../src/templates/staff/circ/share/t_event_override_dialog.tt2 | 2 +- Open-ILS/src/templates/staff/t_splash.tt2 | 4 ++-- 25 files changed, 38 insertions(+), 46 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/booking/reservations-grid.component.ts b/Open-ILS/src/eg2/src/app/staff/booking/reservations-grid.component.ts index 92b23b87d5..8344ee561a 100644 --- a/Open-ILS/src/eg2/src/app/staff/booking/reservations-grid.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/booking/reservations-grid.component.ts @@ -1,5 +1,4 @@ import {Component, EventEmitter, Input, Output, OnChanges, OnInit, ViewChild} from '@angular/core'; -import {Location} from '@angular/common'; import {Router} from '@angular/router'; import {Observable, from, of} from 'rxjs'; import {tap, switchMap, mergeMap} from 'rxjs/operators'; @@ -76,7 +75,6 @@ export class ReservationsGridComponent implements OnChanges, OnInit { returnNotAppropriate: (rows: IdlObject[]) => boolean; constructor( - private ngLocation: Location, private auth: AuthService, private format: FormatService, private pcrud: PcrudService, @@ -173,11 +171,7 @@ export class ReservationsGridComponent implements OnChanges, OnInit { this.viewPatronRecord = (reservations: IdlObject[]) => { const patronIds = reservations.map(reservation => reservation.usr().id()); - window.open( - this.ngLocation.prepareExternalUrl( - '/staff/circ/patron/' + patronIds[0] + '/checkout' - ) - ); + window.open('/eg/staff/circ/patron/' + patronIds[0] + '/checkout'); }; this.noSelectedRows = (rows: IdlObject[]) => (rows.length === 0); diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html index 7de0b03a0e..17c7ffb8d2 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html +++ b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html @@ -6,7 +6,7 @@
Placing hold for patron - + {{holdForUser().pref_family_name() || holdForUser().family_name()}}, {{holdForUser().pref_first_given_name() || holdForUser().first_given_name()}} . diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html index 09f258c8f7..bc6ec77ff1 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html +++ b/Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html @@ -177,7 +177,7 @@ Created {{summary.record.create_date() | date:'shortDate'}} by + href="/eg/staff/circ/patron/{{summary.record.creator().id()}}/checkout"> {{summary.record.creator().usrname()}} @@ -190,7 +190,7 @@
Edited {{summary.record.edit_date() | date:'shortDate'}} by + href="/eg/staff/circ/patron/{{summary.record.editor().id()}}/checkout"> {{summary.record.editor().usrname()}} ... diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html b/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html index 9510b4f64f..07e5c523bf 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html +++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html @@ -32,7 +32,7 @@