From 5e07e9ee7f4e70df62c598547070adb4d80ce66f Mon Sep 17 00:00:00 2001
From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Wed, 9 Apr 2014 09:36:02 +1200
Subject: [PATCH] Fixing the error handling to be consistent

---
 lib/NCIP/Handler/RequestItem.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/NCIP/Handler/RequestItem.pm b/lib/NCIP/Handler/RequestItem.pm
index 4fe5f3f..c12464f 100644
--- a/lib/NCIP/Handler/RequestItem.pm
+++ b/lib/NCIP/Handler/RequestItem.pm
@@ -33,15 +33,15 @@ sub handle {
         my $itemid =
           $xpc->findnodes( 'ns:RequestItem/UniqueItemId/ItemIdentifierValue',
             $root );
-        my $biblionumber = $xpc->findnodes( 'ns://BibliographicRecordIdentifier',
+        my $biblionumber = $xpc->findnodes( '//ns:BibliographicRecordIdentifier',
                       $root );
         # request the item
-        my ( $error, $messages ) = $self->ils->request( $userid, $itemid, $biblionumber );
+        my $result = $self->ils->request( $userid, $itemid, $biblionumber );
         my $vars;
         my $output;
-        my $vars->{'barcode'} = $itemid;
+        $vars->{'barcode'} = $itemid;
         $vars->{'messagetype'} = 'RequestItemResponse';
-        if ($error) {
+        if (! $result->{'success'}) {
             $vars->{'processingerror'}        = 1;
             $vars->{'processingerrortype'}    = $messages;
             $vars->{'processingerrorelement'} = 'UniqueItemIdentifier';
-- 
2.11.0