From 5ee5c4cf81288f25264f4beb99d6bf4d0ae7af12 Mon Sep 17 00:00:00 2001 From: Jane Sandberg Date: Thu, 6 Jun 2019 18:15:56 -0700 Subject: [PATCH] LP1474874: Consistent page headers in the Angular client This commit ensures that each screen in the Angular staff client uses the component to better orient its users. This commit also gives the eg-staff-banner some

semantics, per WebAIM's guidance: "Pages should be structured in a hierarchical manner, generally with one 1st degree headings (

) being the most important (usually page titles or main content heading)" -- https://webaim.org/techniques/semanticstructure/ To test: 1) Go to [your-server]/eg2/en-US/staff/catalog/search 2) Confirm that there is a header that gives the page title at the top of the page. 3) Go to an Angular Vandelay page. 4) Confirm that you see a similar header as in step 2. 5) Go to an Angular Administration page. 6) repeat step 4. Signed-off-by: Jane Sandberg Signed-off-by: Jason Boyer --- Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html | 3 ++- Open-ILS/src/eg2/src/app/staff/catalog/browse.component.html | 2 ++ Open-ILS/src/eg2/src/app/staff/catalog/catalog.component.html | 2 ++ Open-ILS/src/eg2/src/app/staff/catalog/cnbrowse.component.html | 2 ++ Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts | 2 +- 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html b/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html index a81472d674..1a48cac110 100644 --- a/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html +++ b/Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.component.html @@ -1,4 +1,5 @@ - + +