From 63d2569eea4c2192e87e0536ddb0d05021775646 Mon Sep 17 00:00:00 2001 From: miker Date: Thu, 4 Mar 2010 16:16:55 +0000 Subject: [PATCH] preserve time component of original circ when backdating -- mainly to avoid over-voiding billings git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6@15694 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/src/perlmods/OpenILS/Application/Circ.pm | 8 +++++++- Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm | 7 +++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Circ.pm b/Open-ILS/src/perlmods/OpenILS/Application/Circ.pm index e2d573c63b..38674569fa 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Circ.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Circ.pm @@ -305,8 +305,14 @@ sub set_circ_claims_returned { $circ->stop_fines_time('now') unless $circ->stop_fines_time; if( $backdate ) { + $backdate = clense_ISO8601($backdate); + + my $original_date = DateTime::Format::ISO8601->new->parse_datetime(clense_ISO8601($circ->due_date)); + my $new_date = DateTime::Format::ISO8601->new->parse_datetime($backdate); + $backdate = $new_date->ymd . 'T' . $original_date->strftime('%T%z'); + # make it look like the circ stopped at the cliams returned time - $circ->stop_fines_time(clense_ISO8601($backdate)); + $circ->stop_fines_time($backdate); my $evt = OpenILS::Application::Circ::CircCommon->void_overdues($e, $circ, $backdate); return $evt if $evt; } diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm index 3898556e2d..66eea4a027 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Circulate.pm @@ -2587,8 +2587,11 @@ sub checkin_handle_backdate { # clean up the backdate for date comparison # we want any bills created on or after the backdate # ------------------------------------------------------------------ - $bd =~ s/^(\d{4}-\d{2}-\d{2}).*/$1/og; - #$bd = "${bd}T23:59:59"; + my $original_date = DateTime::Format::ISO8601->new->parse_datetime(clense_ISO8601($self->circ->due_date)); + my $new_date = DateTime::Format::ISO8601->new->parse_datetime($bd); + $bd = $new_date->ymd . 'T' . $original_date->strftime('%T%z'); + + $self->backdate($bd); my $bills = $self->editor->search_money_billing( { -- 2.11.0