From 660f5311dfc0fed1b44398b8bcdde7ff9fc29053 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Tue, 27 Apr 2021 13:45:40 -0400 Subject: [PATCH] LP1904036 Transit audio timing repair Ensure the ROUTE_ITEM audio alert happens regardless of whether the route dialog will be displayed. Signed-off-by: Bill Erickson Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton --- Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts | 2 ++ Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts index 1a7046100d..bb233c35f2 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts @@ -859,6 +859,8 @@ export class CircService { return this.showPrecatAlert().then(_ => result); case 'ROUTE_ITEM': + this.audio.play(result.hold ? + 'info.checkin.transit.hold' : 'info.checkin.transit'); this.components.routeDialog.checkin = result; return this.components.routeDialog.open().toPromise() .then(_ => result); diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts index 4f0489266a..3cafd9df9b 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts @@ -11,7 +11,6 @@ import {NgbModal, NgbModalOptions} from '@ng-bootstrap/ng-bootstrap'; import {DialogComponent} from '@eg/share/dialog/dialog.component'; import {CheckinResult} from './circ.service'; import {ServerStoreService} from '@eg/core/server-store.service'; -import {AudioService} from '@eg/share/util/audio.service'; import {PrintService} from '@eg/share/print/print.service'; /** Route Item Dialog */ @@ -32,7 +31,6 @@ export class RouteDialogComponent extends DialogComponent { private pcrud: PcrudService, private org: OrgService, private circ: CircService, - private audio: AudioService, private printer: PrintService, private serverStore: ServerStoreService) { super(modal); @@ -94,9 +92,6 @@ export class RouteDialogComponent extends DialogComponent { }); } - this.audio.play(hold ? - 'info.checkin.transit.hold' : 'info.checkin.transit'); - if (this.checkin.params.auto_print_hold_transits || this.circ.suppressCheckinPopups) { // Print and exit. -- 2.11.0