From 68e096cb240204de0a61b595e3cce847c2e52328 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 28 May 2019 11:00:39 -0400
Subject: [PATCH] LP1823367 Catalog ident query improvements

* Default to ISBN search in the identifier query form.

* Remove the disabled "call number browse" entry from the identifier
  query type selector, since CN browse now has a dedicated tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
 Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html | 1 -
 Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.ts   | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html
index 72386f2621..d032f3d08f 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html
@@ -224,7 +224,6 @@ TODO focus search input
                   [(ngModel)]="context.identSearch.queryType">
                   <option i18n value="identifier|isbn">ISBN</option>
                   <option i18n value="identifier|issn">ISSN</option>
-                  <option i18n disabled value="cnbrowse">Call Number (Shelf Browse)</option>
                   <option i18n value="identifier|lccn">LCCN</option>
                   <option i18n value="identifier|tcn">TCN</option>
                   <option i18n value="item_barcode">Item Barcode</option>
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.ts
index 0e010eb5ca..84dd830538 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.ts
@@ -59,6 +59,10 @@ export class SearchFormComponent implements OnInit, AfterViewInit {
         // Avoid changing the tab in the lifecycle hook thread.
         setTimeout(() => {
 
+            if (this.context.identSearch.queryType === '') {
+                this.context.identSearch.queryType = 'identifier|isbn';
+            }
+
             // Apply a tab if none was already specified
             if (!this.searchTab) {
                 // Assumes that only one type of search will be searchable
-- 
2.11.0