From 6b0608fe65f2aa60a426f8d3dda25bcfcbf0b6eb Mon Sep 17 00:00:00 2001
From: Rogan Hamby <rogan.hamby@gmail.com>
Date: Fri, 17 Jun 2022 13:29:41 -0400
Subject: [PATCH] LP#1978978: Remove public flag from biblio.record_note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
---
 Open-ILS/examples/fm_IDL.xml                                       | 1 -
 Open-ILS/src/sql/Pg/010.schema.biblio.sql                          | 1 -
 .../sql/Pg/upgrade/xxxx.schema.drop_public_flag_record_notes.sql   | 7 +++++++
 3 files changed, 7 insertions(+), 2 deletions(-)
 create mode 100644 Open-ILS/src/sql/Pg/upgrade/xxxx.schema.drop_public_flag_record_notes.sql

diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml
index a4fb45b078..adacfda200 100644
--- a/Open-ILS/examples/fm_IDL.xml
+++ b/Open-ILS/examples/fm_IDL.xml
@@ -7628,7 +7628,6 @@ SELECT  usr,
 			<field reporter:label="Last Edit Date" name="edit_date" reporter:datatype="timestamp"/>
 			<field reporter:label="Editor" name="editor" reporter:datatype="link"/>
 			<field reporter:label="Note ID" name="id" reporter:datatype="id" />
-			<field reporter:label="Public" name="pub" reporter:datatype="bool"/>
 			<field reporter:label="Bib Record" name="record" reporter:datatype="link"/>
 			<field reporter:label="Note" name="value" reporter:datatype="text"/>
 			<field reporter:label="Deleted" name="deleted" reporter:datatype="bool"/> 
diff --git a/Open-ILS/src/sql/Pg/010.schema.biblio.sql b/Open-ILS/src/sql/Pg/010.schema.biblio.sql
index 12731d2446..350ce4cd95 100644
--- a/Open-ILS/src/sql/Pg/010.schema.biblio.sql
+++ b/Open-ILS/src/sql/Pg/010.schema.biblio.sql
@@ -74,7 +74,6 @@ CREATE TABLE biblio.record_note (
 	value		TEXT		NOT NULL,
 	creator		INT		NOT NULL DEFAULT 1,
 	editor		INT		NOT NULL DEFAULT 1,
-	pub		BOOL		NOT NULL DEFAULT FALSE,
 	deleted         BOOL            NOT NULL DEFAULT FALSE,
 	create_date	TIMESTAMP WITH TIME ZONE	NOT NULL DEFAULT now(),
 	edit_date	TIMESTAMP WITH TIME ZONE	NOT NULL DEFAULT now()
diff --git a/Open-ILS/src/sql/Pg/upgrade/xxxx.schema.drop_public_flag_record_notes.sql b/Open-ILS/src/sql/Pg/upgrade/xxxx.schema.drop_public_flag_record_notes.sql
new file mode 100644
index 0000000000..03a24c8d8e
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/xxxx.schema.drop_public_flag_record_notes.sql
@@ -0,0 +1,7 @@
+BEGIN;
+
+SELECT evergreen.upgrade_deps_block_check('xxxx', :eg_version);
+
+ALTER TABLE biblio.record_note DROP COLUMN pub;
+
+COMMIT;
-- 
2.11.0