From 70120afae4774cafdd6362c517237808a49d5145 Mon Sep 17 00:00:00 2001
From: Jason Boyer <jboyer@library.in.gov>
Date: Thu, 19 Jul 2018 14:29:32 -0400
Subject: [PATCH] LP1782631: Stop Styling Grocery Bills as Overdues
Only checking for the lack of a value in the
checkin_time field causes grocery bills to still
trigger the bill colorizing feature, but because
they have no stop_fines reason they're colored
the same as an overdue item.
This patch requires the presence of a due_date
field before coloring a bill row.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
---
Open-ILS/web/js/ui/default/staff/circ/patron/bills.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js b/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
index 63a7121172..8f4157fc12 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
@@ -223,7 +223,7 @@ function($scope , $q , $routeParams , egCore , egConfirmDialog , $location,
// Apply coloring to rows based on fines stop reason
$scope.colorizeBillsList = {
apply: function(item) {
- if (!item['circulation.checkin_time']) {
+ if (item['circulation.due_date'] && !item['circulation.checkin_time']) {
if (item['circulation.stop_fines'] == 'LOST') {
return 'lost-row';
} else if (item['circulation.stop_fines'] == 'LONGOVERDUE') {
@@ -240,7 +240,7 @@ function($scope , $q , $routeParams , egCore , egConfirmDialog , $location,
isEnabled: true,
template: function(item) {
var icon = '';
- if (!item['circulation.checkin_time']) {
+ if (item['circulation.due_date'] && !item['circulation.checkin_time']) {
if (item['circulation.stop_fines'] == "LOST") {
icon = 'glyphicon-question-sign';
} else if (item['circulation.stop_fines'] == "LONGOVERDUE") {
--
2.11.0