From 71f8ecdcdaa2c27ebc708887ed1e3e3f05f85b6c Mon Sep 17 00:00:00 2001
From: Katlyn Beck <kbeck@catalyte.io>
Date: Tue, 19 Mar 2019 23:31:33 +0000
Subject: [PATCH] CAT-199 getLocalItems to getItems

- Refactor implementation of search pane and browse search default value
retrieval when searching the catalog.

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>

 Changes to be committed:
	modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
---
 .../web/js/ui/default/staff/cat/catalog/app.js     | 40 +++++++++++++++-------
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
index 19bdc91071..fc6441ee57 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
@@ -1940,27 +1940,41 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
         // if we're displaying the advanced search form, select
         // whatever default pane the user has chosen via workstation
         // preference
+        var search_promises = [];
         if (url.match(/\/opac\/advanced$/)) {
-            egCore.hatch.getItem('eg.search.adv_pane').then(function(adv_pane_val){
-                if (adv_pane_val) {
-                    url += '?pane=' + encodeURIComponent(adv_pane_val);
+            search_promises.push(
+                egCore.hatch.getItem('eg.search.adv_pane').then(
+                    function(adv_pane) {
+                        $scope.adv_pane = adv_pane;
+                    }
+                )
+            );
+        }
+        // if we're displaying the browse search form,
+        // select whatever browse sort default the user
+        // has chosen via workstation preference
+        $scope.browse_sort_default;
+        search_promises.push(
+			egCore.hatch.getItem('eg.search.browse_sort_default').then(
+                function(browse_sort_default) {
+                    $scope.browse_sort_default = browse_sort_default;
                 }
+            )
+        );
 
+        if (search_promises.length) {
+            $q.all(search_promises).then(function(success) {
+                if ($scope.adv_pane) {
+                    url += '?pane=' + encodeURIComponent($scope.adv_pane);
+                }
+                if ($scope.adv_pane == 'browse' && $scope.browse_sort_default ) {
+                    url += '&sort=' + encodeURIComponent($scope.browse_sort_default);
+                }
                 $scope.catalog_url = url;
             });
         } else {
             $scope.catalog_url = url;
         }
-        
-        // if we're displaying the browse search form,
-        // select whatever browse sort default the user
-        // has chosen via workstation preference
-        if (url.match(/\?pane=browse/)) {
-            var browse_sort_default = egCore.hatch.getLocalItem('eg.search.browse_sort_default');
-            if (browse_sort_default) {
-                url += '&sort=' + encodeURIComponent(browse_sort_default);
-            }
-        }
     }
 
     function init_parts_url() {
-- 
2.11.0