From 722a63be2680a9bfb447de26079c13a396233f35 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 8 Apr 2021 10:30:56 -0400
Subject: [PATCH] LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../eg2/src/app/staff/acq/lineitem/lineitem-list.component.html    | 2 +-
 Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html        | 7 +++++--
 Open-ILS/web/js/ui/default/staff/package.json                      | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
index db9d35b16d..c8588b56e2 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/lineitem/lineitem-list.component.html
@@ -242,7 +242,7 @@
                 <span i18n>{{li.purchase_order().id()}}</span>
               </a>
             </ng-container>
-            <ng-container *ngIf="!picklistId && li.picklist()">
+            <ng-container *ngIf="!picklistId && li.picklist() && li.picklist().name()">
               <span class="ml-1 mr-1" i18n> | </span>
               <a class="label-with-material-icon"
                 title="Selection List" i18n-title 
diff --git a/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html b/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
index 7f7b218050..a094da60c2 100644
--- a/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/acq/po/create.component.html
@@ -17,13 +17,16 @@
   </div>
   <div class="form-group">
     <label for="name-input" i18n>Provider</label>
-    <eg-combobox domId="provider-input" [(ngModel)]="provider" idlClass="acqpro">
+    <eg-combobox domId="provider-input" [(ngModel)]="provider" 
+      [idlQueryAnd]="{active: 't'}" idlClass="acqpro">
     </eg-combobox>
   </div>
   <div class="form-group form-check">
     <input type="checkbox" class="form-check-input" 
       [(ngModel)]="prepaymentRequired" id="prepayment-required">
-    <label class="form-check-label" for="prepayment-required" i18n>Prepayment Required</label>
+    <label class="form-check-label" for="prepayment-required" i18n>
+      Prepayment Required
+    </label>
   </div>
   <div class="form-group form-check">
     <input type="checkbox" class="form-check-input" 
diff --git a/Open-ILS/web/js/ui/default/staff/package.json b/Open-ILS/web/js/ui/default/staff/package.json
index 3dae5151e9..d08acf32d6 100644
--- a/Open-ILS/web/js/ui/default/staff/package.json
+++ b/Open-ILS/web/js/ui/default/staff/package.json
@@ -13,6 +13,7 @@
     "karma-jasmine": "^1.1.1",
     "karma-chrome-launcher": "^3.1.0",
     "karma-firefox-launcher": "^1.2.0",
+    "karma-jasmine": "^1.1.1",
     "karma-script-launcher": "^1.0.0",
     "karma-spec-reporter": "0.0.32",
     "karma-story-reporter": "^0.3.1",
-- 
2.11.0