From 731012b0b6ef1e47205953dd9601b609e93155da Mon Sep 17 00:00:00 2001 From: Dan Allen Date: Wed, 30 Dec 2020 02:55:26 -0700 Subject: [PATCH] rename octicons.svg to octicons-16.svg and remove size suffix from IDs --- gulp.d/tasks/build.js | 2 +- src/img/{octicons.svg => octicons-16.svg} | 10 +++++----- src/js/06-copy-to-clipboard.js | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) rename src/img/{octicons.svg => octicons-16.svg} (84%) diff --git a/gulp.d/tasks/build.js b/gulp.d/tasks/build.js index 64642ad..6f213e2 100644 --- a/gulp.d/tasks/build.js +++ b/gulp.d/tasks/build.js @@ -110,7 +110,7 @@ module.exports = (src, dest, preview) => () => { imagemin.optipng(), imagemin.svgo({ plugins: [ - { cleanupIDs: { preservePrefixes: ['symbol-', 'view-'] } }, + { cleanupIDs: { preservePrefixes: ['icon-', 'view-'] } }, { removeViewBox: false }, { removeDesc: false }, ], diff --git a/src/img/octicons.svg b/src/img/octicons-16.svg similarity index 84% rename from src/img/octicons.svg rename to src/img/octicons-16.svg index 3503b58..d8415d0 100644 --- a/src/img/octicons.svg +++ b/src/img/octicons-16.svg @@ -1,5 +1,5 @@ - - Octicons (subset) + + Octicons (16px subset) Octicons v11.2.0 by GitHub - https://primer.style/octicons/ - License: MIT - + - - + + diff --git a/src/js/06-copy-to-clipboard.js b/src/js/06-copy-to-clipboard.js index 4749373..cc9a270 100644 --- a/src/js/06-copy-to-clipboard.js +++ b/src/js/06-copy-to-clipboard.js @@ -34,7 +34,7 @@ svg.setAttribute('aria-hidden', 'true') svg.setAttribute('class', 'copy-icon') var use = document.createElementNS('http://www.w3.org/2000/svg', 'use') - use.setAttribute('href', window.uiRootPath + '/img/octicons.svg#symbol-clippy-16') + use.setAttribute('href', window.uiRootPath + '/img/octicons-16.svg#icon-clippy') svg.appendChild(use) copy.appendChild(svg) ;(toast = document.createElement('span')).className = 'copy-toast' -- 2.11.0