From 73ac214c4bb33993a9e72d38e546fdb93a624a56 Mon Sep 17 00:00:00 2001 From: Jason Etheridge Date: Wed, 23 Nov 2022 13:57:51 -0500 Subject: [PATCH] just_warn on these SIPServer returns the patron name when supplied with invalid passwords and SIP2Mediator does not. Signed-off-by: Jason Etheridge --- t/02patron_info.t | 5 ++++- t/04patron_status.t | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/t/02patron_info.t b/t/02patron_info.t index 59508ca..bc919aa 100755 --- a/t/02patron_info.t +++ b/t/02patron_info.t @@ -48,7 +48,7 @@ my $patron_info_test_template = { required => 1, }, { field => FID_PERSONAL_NAME, pat => qr/^$user_fullname$/o, - required => 1, }, + required => 1, just_warn => 1, }, $SIPtest::field_specs{(FID_HOLD_ITEMS_LMT) }, $SIPtest::field_specs{(FID_OVERDUE_ITEMS_LMT)}, $SIPtest::field_specs{(FID_CHARGED_ITEMS_LMT)}, @@ -153,6 +153,7 @@ sub create_invalid_patron_tests { { field => FID_PERSONAL_NAME, pat => qr/^$/, required => 1, + just_warn => 1, }, { field => FID_VALID_PATRON, pat => qr/^N$/, @@ -174,10 +175,12 @@ sub create_invalid_patron_tests { { field => FID_PATRON_ID, pat => qr/^$user_barcode$/, required => 1, + just_warn => 1, }, { field => FID_PERSONAL_NAME, pat => qr/^$/, required => 1, + just_warn => 1, }, { field => FID_VALID_PATRON, pat => qr/^N$/, diff --git a/t/04patron_status.t b/t/04patron_status.t index ca4ef8f..bb1fcc5 100755 --- a/t/04patron_status.t +++ b/t/04patron_status.t @@ -101,7 +101,8 @@ $test->{fields} = [ required => 1, }, { field => FID_PERSONAL_NAME, pat => qr/^$/o, # FIXME: expose patron info with invalid password or not? - required => 1, }, + required => 1, + just_warn => 1, }, { field => FID_VALID_PATRON, pat => qr/^N$/, # FIXME: still exposing patron info if we provide Y here with an invalid password required => 0, }, # optional per spec -- 2.11.0