From 7777c3dfecbfd020b48a967a4a7bb562fa5adc66 Mon Sep 17 00:00:00 2001 From: Thomas Berezansky Date: Tue, 3 Apr 2012 14:45:10 -0400 Subject: [PATCH] Fix some "null" instead of blank values in JSPac Signed-off-by: Thomas Berezansky Signed-off-by: Michael Peters Signed-off-by: Lebbeous Fogle-Weekley --- Open-ILS/web/opac/skin/default/js/holds.js | 2 +- Open-ILS/web/opac/skin/default/js/myopac.js | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Open-ILS/web/opac/skin/default/js/holds.js b/Open-ILS/web/opac/skin/default/js/holds.js index bae8032062..be6087fb5e 100644 --- a/Open-ILS/web/opac/skin/default/js/holds.js +++ b/Open-ILS/web/opac/skin/default/js/holds.js @@ -508,7 +508,7 @@ function __holdsDrawWindow() { } - $('holds_phone').value = holdArgs.recipient.day_phone(); + $('holds_phone').value = (holdArgs.recipient.day_phone() ? holdArgs.recipient.day_phone() : ''); appendClear( $('holds_email'), text(holdArgs.recipient.email())); var pref = holdArgs.recipient.prefs[PREF_HOLD_NOTIFY]; diff --git a/Open-ILS/web/opac/skin/default/js/myopac.js b/Open-ILS/web/opac/skin/default/js/myopac.js index 992b7ea354..c2dd961ec7 100644 --- a/Open-ILS/web/opac/skin/default/js/myopac.js +++ b/Open-ILS/web/opac/skin/default/js/myopac.js @@ -864,9 +864,11 @@ function _myOPACSummaryShowUer(r) { unHideMe($('myopac.expired.alert')); } - var iv1 = user.ident_value()+''; - if (iv1.length > 4 && iv1.match(/\d{4}/)) iv1 = iv1.substring(0,4) + '***********'; - + var iv1 = ''; + if (user.ident_value()) { + iv1 = user.ident_value()+''; + if (iv1.length > 4 && iv1.match(/\d{4}/)) iv1 = iv1.substring(0,4) + '***********'; + } appendClear($('myopac_summary_prefix'),text(user.prefix())); appendClear($('myopac_summary_first'),text(user.first_given_name())); -- 2.11.0