From 7a8d6d658b1128f3d93b97936f31a7c2c1fe283c Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Tue, 13 Apr 2021 12:31:36 -0400 Subject: [PATCH] LP1904036 lint and repairs Signed-off-by: Bill Erickson Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton --- .../src/app/staff/circ/checkin/checkin.component.html | 7 +++---- .../src/app/staff/circ/checkin/checkin.component.ts | 1 + .../eg2/src/app/staff/circ/patron/perms.component.ts | 6 +++--- .../src/eg2/src/app/staff/share/circ/circ.service.ts | 18 ++++++++---------- .../src/app/staff/share/circ/route-dialog.component.ts | 2 +- 5 files changed, 16 insertions(+), 18 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html index 0ad28c6787..91a64b3c9b 100644 --- a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html +++ b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.html @@ -12,8 +12,7 @@ Barcode
Effective Date: - +
diff --git a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts index 52543b52ee..f07d5edd60 100644 --- a/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/circ/checkin/checkin.component.ts @@ -16,6 +16,7 @@ import {BarcodeSelectComponent interface CheckinGridEntry extends CheckinResult { // May need to extend... + foo?: number; // Empty interfaces are not allowed. } @Component({ diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts b/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts index 0e8eec6b42..1c2045f26e 100644 --- a/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/perms.component.ts @@ -22,7 +22,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit { @Input() patronId: number; - myPermMaps: {[permId: number]: IdlObject} = {} + myPermMaps: {[permId: number]: IdlObject} = {}; userPermMaps: {[permId: number]: IdlObject} = {}; userWorkOuMaps: {[orgId: number]: IdlObject} = {}; @@ -79,7 +79,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit { .then(_ => { this.progress.increment(); - return this.perms.hasWorkPermAt(['ASSIGN_WORK_ORG_UNIT'], true) + return this.perms.hasWorkPermAt(['ASSIGN_WORK_ORG_UNIT'], true); }) .then(perms => { @@ -233,7 +233,7 @@ export class PatronPermsComponent implements OnInit, AfterViewInit { 'open-ils.actor', 'open-ils.actor.user.permissions.update', this.auth.token(), permMaps - ) + ); })) .pipe(concatMap(_ => this.reload())) .pipe(finalize(() => this.loading = false)).subscribe(); diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts index ae7f817812..eb51abc44b 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/circ/circ.service.ts @@ -411,10 +411,10 @@ export class CircService { // which is OK. if (!payload) { return Promise.resolve(result); } - result.circ = payload.circ, - result.copy = payload.copy, - result.record = payload.record, - result.nonCatCirc = payload.noncat_circ + result.circ = payload.circ; + result.copy = payload.copy; + result.record = payload.record; + result.nonCatCirc = payload.noncat_circ; return this.fleshCommonData(result); } @@ -467,7 +467,7 @@ export class CircService { } exitAlert(context: any): Promise { - let key = 'staff.circ.events.' + context.textcode; + const key = 'staff.circ.events.' + context.textcode; return this.strings.interpolate(key, context) .then(str => { this.components.circFailedDialog.dialogBody = str; @@ -491,15 +491,15 @@ export class CircService { // we have the specifics on the copy, go ahead and // copy them into the params we use for the follow // up checkout. - result.params.copy_barcode = result.copy.barcode() - result.params.copy_id = result.copy.id() + result.params.copy_barcode = result.copy.barcode(); + result.params.copy_id = result.copy.id(); return this.checkout(result.params); }); } else { return result; } - }) + }); } // Ask the user if we should resolve the circulation and check @@ -723,8 +723,6 @@ export class CircService { const circ = result.circ; const parent_circ = result.parent_circ; - let promise = Promise.resolve(); - if (transit) { if (typeof transit.dest() !== 'object') { transit.dest(this.org.get(transit.dest())); diff --git a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts index aa90d3fb81..4f0489266a 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/share/circ/route-dialog.component.ts @@ -80,7 +80,7 @@ export class RouteDialogComponent extends DialogComponent { }) .then(addr => { this.checkin.destAddress = addr; - return this.org.settings('lib.courier_code', this.checkin.destOrg.id()) + return this.org.settings('lib.courier_code', this.checkin.destOrg.id()); }) .then(sets => this.checkin.destCourierCode = sets['lib.courier_code']); -- 2.11.0