From 7b75e501ea3485fee9a9edf32d712ad113ed2cf0 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Fri, 20 May 2016 11:18:14 -0700 Subject: [PATCH] JBAS-1426 Classroom cards generator improve error handling Signed-off-by: Bill Erickson --- .../classroom_cards/tools/classroom-cards-generator.pl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/KCLS/utility-scripts/import_students/classroom_cards/tools/classroom-cards-generator.pl b/KCLS/utility-scripts/import_students/classroom_cards/tools/classroom-cards-generator.pl index 7414f6effd..a162bd1d8e 100755 --- a/KCLS/utility-scripts/import_students/classroom_cards/tools/classroom-cards-generator.pl +++ b/KCLS/utility-scripts/import_students/classroom_cards/tools/classroom-cards-generator.pl @@ -9,6 +9,7 @@ use strict; use warnings; use Text::CSV; my $default_dob = '1900-01-01'; +my @required = qw/first_given_name family_name street1 city post_code/; my $csv_file = $ARGV[0] or die "School info CSV file required\n"; @@ -35,6 +36,13 @@ print "action,student_id,first_given_name,". my $student_id = 0; while (my $school = $csv->getline_hr($fh)) { + for my $field (@required) { + next if $school->{$field}; + warn "\n===\nMissing value for required field: $field\n===\n"; + warn $_ . " => " . ($school->{$_} || '') . "\n" for @required; + exit 1; + } + for my $idx (0..49) { print sprintf("C,%04d,%s,%s,%s,%s,%s,%s,%s\n", $student_id++, -- 2.11.0