From 83207274f34679917b1ba79e49c8ad638e7e346a Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Thu, 10 Mar 2016 12:57:26 -0500 Subject: [PATCH] LP#1549505: fix rating.percent_time_circulating() Fixes an issue with the item age calculation; not all items will have a non-NULL active_date. This led to return records with a NULL time circulating value, meaning that they didn't get excluded by the percentile filter. Signed-off-by: Galen Charlton --- Open-ILS/src/sql/Pg/upgrade/XXXX.schema.statisitcal-ratings.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.schema.statisitcal-ratings.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.schema.statisitcal-ratings.sql index 2b3e1adfff..b9e70167e7 100644 --- a/Open-ILS/src/sql/Pg/upgrade/XXXX.schema.statisitcal-ratings.sql +++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.schema.statisitcal-ratings.sql @@ -890,7 +890,7 @@ BEGIN SUM(COALESCE(circ_time,0))::NUMERIC / SUM(age)::NUMERIC FROM (SELECT cn.record AS bib, cp.id, - EXTRACT( EPOCH FROM AGE(cp.active_date) ) + 1 AS age, + EXTRACT( EPOCH FROM AGE(COALESCE(cp.active_date, cp.create_date)) ) + 1 AS age, SUM( -- time copy spent circulating EXTRACT( EPOCH FROM -- 2.11.0