From 85c95a17b5346e9c6c1d6b14a2fad056baf16c2d Mon Sep 17 00:00:00 2001 From: Josh Stompro Date: Thu, 28 Feb 2019 09:43:49 -0600 Subject: [PATCH] LP#1778783 - Circulate.pm fix log_me correct barcode var The log_me sub wasn't using the correct variable for showing the entered barcode. It should be $self->copy_barcode instead of $self->barcode. Testing Notes: Before fix: 1. Watch the logs with something like tail -f osrfsys.log | fgrep 'circulator: do_permit()' 2. Perform a checkout of a non-existant barcode. 3. Notice that the entered barcode is missing after 'copy=' After fix: 1. Restart the circ openils service osrf_control -l --service open-ils.circ --restart 2. Watch the logs. 3. Perform a checkout of a non-existant barcode. 4. Notice that the barcode is now shown after 'copy=' Signed-off-by: Josh Stompro Signed-off-by: Bill Erickson --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm index 40fe4b0c84..ffb5a622b0 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm @@ -4059,7 +4059,7 @@ sub checkin_flesh_events { sub log_me { my( $self, $msg ) = @_; my $bc = ($self->copy) ? $self->copy->barcode : - $self->barcode; + $self->copy_barcode; $bc ||= ""; my $usr = ($self->patron) ? $self->patron->id : ""; $logger->info("circulator: $msg requestor=".$self->editor->requestor->id. -- 2.11.0