From 9266a76a9f11fcc419e38d99a114216b9266aef6 Mon Sep 17 00:00:00 2001
From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 12 Jun 2018 12:01:15 -0400
Subject: [PATCH] LP#1755258 Improve network error handling
Improve promise handling and logging in browser client network request
failure handling.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
Open-ILS/web/js/ui/default/staff/services/net.js | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/Open-ILS/web/js/ui/default/staff/services/net.js b/Open-ILS/web/js/ui/default/staff/services/net.js
index 26eb31c6dc..8415dc59e7 100644
--- a/Open-ILS/web/js/ui/default/staff/services/net.js
+++ b/Open-ILS/web/js/ui/default/staff/services/net.js
@@ -111,13 +111,16 @@ function($q, $rootScope, egEvent) {
// bother JSON-ifying it, since there is the off
// chance that JSON-ification could fail, e.g if
// the object has circular refs.
- console.error(request.method +
- ' (' + request.params + ') failed. See server logs.');
- deferred.reject(msg);
+ var note = request.method +
+ ' (' + request.params + ') failed. See server logs.';
+ console.error(note, msg);
+ request.deferred.reject(note);
},
onmethoderror : function(req, statCode, statMsg) {
- console.error('error calling method ' +
- request.method + ' : ' + statCode + ' : ' + statMsg);
+ var msg = 'error calling method ' +
+ request.method + ' : ' + statCode + ' : ' + statMsg;
+ console.error(msg);
+ request.deferred.reject(msg);
}
}).send();
--
2.11.0