From 94d3609baf338ead2ff26a1f29384a70dcccc33e Mon Sep 17 00:00:00 2001 From: Garry Collum Date: Thu, 18 Mar 2021 15:56:04 -0400 Subject: [PATCH] LP1917944-Hold Pickup Library sometimes Empty Checks to make sure that the opac.default_pickup_location in usr_setting has a value. To test. 1. The patron must have a opac.default_pickup_location set to "" 2. Place a hold for this patron. 3. Notice that the pickup location is blank. 4. Apply the patch. 5. The hold pickup location should now be filled with the patron's home library. To re-create this in concerto you may have to tweak the usr_setting table. 1. Assign a default pickup location to a patron. 2. Find the id field for the above in the usr_setting table. select * from actor.usr_setting; 3. Update the setting. update actor.usr_setting set value = '""' where id = ; Signed-off-by: Garry Collum Signed-off-by: Michele Morgan --- Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts index c2271a2e1c..4aaf7fa013 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts +++ b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.ts @@ -439,7 +439,8 @@ export class HoldComponent implements OnInit { break; case 'opac.default_pickup_location': - this.pickupLib = Number(value); + if(value) + this.pickupLib = Number(value); break; case 'opac.default_phone': -- 2.11.0