From 95a3e7c4c5f45a9e2d88f7837c3f08bbeb57d1d1 Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Thu, 6 Sep 2012 12:25:01 -0400 Subject: [PATCH] TPAC: Escape single quotes in MFHD record location If an MFHD record contains an 852 field with a subfield containing a single quote, the unescaped single quote is introduced directly into the value of the JavaScript hash that uses single quotes as delimiters - thereby generating a JS exception and preventing the staff client from properly populating the MFHD Editor menu. This commit escapes incoming single quotes from the MFHD location field to prevent that from happening. The other fields in the JS hash are numeric and therefore should not need escaping. Signed-off-by: Dan Scott Signed-off-by: Lebbeous Fogle-Weekley --- Open-ILS/src/templates/opac/parts/js.tt2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/templates/opac/parts/js.tt2 b/Open-ILS/src/templates/opac/parts/js.tt2 index b4a775df99..d6cacbef5b 100644 --- a/Open-ILS/src/templates/opac/parts/js.tt2 +++ b/Open-ILS/src/templates/opac/parts/js.tt2 @@ -23,7 +23,7 @@ [% FOR summary IN ctx.mfhd_summaries %] { 'id' : '[% summary.sre_id %]', - 'label' : '[% summary.location %]', + 'label' : '[% summary.location | replace("'", "\\'") %]', 'entryNum' : '[% loop.index %]', 'owning_lib' : '[% summary.owning_lib %]' }, -- 2.11.0