From 97fd7113783e0de46e826f994ad61b2ea7854459 Mon Sep 17 00:00:00 2001 From: Thomas Berezansky Date: Thu, 12 Jul 2012 11:42:21 -0400 Subject: [PATCH] Remove an extra ternary op And adjust the comment to make more sense. There is no higher level filter that prevents copy holds on parted items, so there is no filter for them to "slip through". Signed-off-by: Thomas Berezansky Signed-off-by: Ben Shum --- .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index 5c47b5eb1c..83cd9f0827 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -1253,8 +1253,8 @@ sub new_hold_copy_targeter { isTrue($_->holdable) && !isTrue($_->deleted) && (isTrue($hold->mint_condition) ? isTrue($_->mint_condition) : 1) && - ( ($hold->hold_type ne 'C' && $hold->hold_type ne 'I') ? # Copy-ish holds can target if they slipped through - ($hold->hold_type ne 'P' ? $_->part_maps->count == 0 : 1) : 1 ) + ( ( $hold->hold_type ne 'C' && $hold->hold_type ne 'I' # Copy-level holds don't care about parts + && $hold->hold_type ne 'P' ) ? $_->part_maps->count == 0 : 1) } @$all_copies; } -- 2.11.0