From 989579ab508ede9747b9e60a42c103b77f8eb016 Mon Sep 17 00:00:00 2001 From: Jason Etheridge Date: Mon, 6 Jun 2011 12:46:21 -0400 Subject: [PATCH] fix View Holds by preventing an empty IN list with cstore, and stubbing out part_holds Signed-off-by: Jason Etheridge Signed-off-by: Jason Stephenson --- .../src/perlmods/lib/OpenILS/Application/Circ/Holds.pm | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm index ddfd0ad0d2..1be6838ae2 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm @@ -2750,7 +2750,7 @@ sub all_rec_holds { $args->{fulfillment_time} = undef; # we don't want to see old fulfilled holds $args->{cancel_time} = undef; - my $resp = { volume_holds => [], copy_holds => [], metarecord_holds => [], issuance_holds => [] }; + my $resp = { volume_holds => [], copy_holds => [], metarecord_holds => [], part_holds => [], issuance_holds => [] }; my $mr_map = $e->search_metabib_metarecord_source_map({source => $title_id})->[0]; if($mr_map) { @@ -2774,12 +2774,14 @@ sub all_rec_holds { record => $title_id }, {idlist=>1} ); - $resp->{part_holds} = $e->search_action_hold_request( - { - hold_type => OILS_HOLD_TYPE_MONOPART, - target => $parts, - %$args - }, {idlist=>1} ); + if (@$parts) { + $resp->{part_holds} = $e->search_action_hold_request( + { + hold_type => OILS_HOLD_TYPE_MONOPART, + target => $parts, + %$args + }, {idlist=>1} ); + } my $subs = $e->search_serial_subscription( { record_entry => $title_id }, {idlist=>1}); -- 2.11.0