From 9b7a29a7953604f41050340d81d3dfdc18eafbdb Mon Sep 17 00:00:00 2001
From: Jane Sandberg <sandbej@linnbenton.edu>
Date: Tue, 16 Mar 2021 19:37:00 -0700
Subject: [PATCH] LP1898114: Add org selector to holds pull list

To test:
1) Go to the Holds Pull List
2) Try looking at the hold lists for all libraries where
you have the VIEW_HOLD permission.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---
 .../src/templates/staff/circ/holds/t_pull_list.tt2    | 10 ++++++++++
 Open-ILS/web/js/ui/default/staff/circ/holds/app.js    | 19 ++++++++++++++++---
 .../Circulation/holds_pull_list_selector.adoc         |  7 +++++++
 3 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Circulation/holds_pull_list_selector.adoc

diff --git a/Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2 b/Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2
index eda5f059ef..0245a4e3f3 100644
--- a/Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2
+++ b/Open-ILS/src/templates/staff/circ/holds/t_pull_list.tt2
@@ -1,3 +1,13 @@
+<div class="row">
+  <div class="col-md-4">
+    <div class="form-group">
+      <label>[% l('View pull list for: ') %]&nbsp; </label>
+      <eg-org-selector id="org_unit" selected="org_unit"
+        onchange="update_org_unit" disable-test="cant_have_volumes">
+      </eg-org-selector>
+    </div>
+  </div>
+</div>
 <eg-grid
   id-field="id"
   idl-class="ahopl"
diff --git a/Open-ILS/web/js/ui/default/staff/circ/holds/app.js b/Open-ILS/web/js/ui/default/staff/circ/holds/app.js
index 08701c206a..9f4e1ce625 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/holds/app.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/holds/app.js
@@ -334,10 +334,14 @@ function($scope , $q , $routeParams , $window , $location , egCore ,
 
     egCore.strings.setPageTitle(egCore.strings['PULL_LIST_TITLE']);
 
+    function current_query() {
+        var org_id = $scope.org_unit ? $scope.org_unit.id() :
+            egCore.auth.user().ws_ou();
+        return {'copy_circ_lib_id' : org_id};
+    }
+
     $scope.gridControls = {
-        setQuery : function() {
-            return {'copy_circ_lib_id' : egCore.auth.user().ws_ou()}
-        },
+        setQuery : current_query,
         setSort : function() {
             return ['copy_location_order_position','call_number_sort_key']
         },
@@ -471,5 +475,14 @@ function($scope , $q , $routeParams , $window , $location , egCore ,
         ).finally(egProgressDialog.close);
     }
 
+    $scope.update_org_unit = function (org) {
+        $scope.org_unit = org;
+        $scope.gridControls.setQuery(current_query());
+        $scope.gridControls.refresh();
+    };
+
+    $scope.cant_have_volumes =
+        function (id) { return !egCore.org.CanHaveVolumes(id); };
+
 }])
 
diff --git a/docs/RELEASE_NOTES_NEXT/Circulation/holds_pull_list_selector.adoc b/docs/RELEASE_NOTES_NEXT/Circulation/holds_pull_list_selector.adoc
new file mode 100644
index 0000000000..489e2700ff
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Circulation/holds_pull_list_selector.adoc
@@ -0,0 +1,7 @@
+Library selector on the holds pull list
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The holds pull list screen now includes a library/org unit selector.
+This allows staff to view the pull list of any library where they have
+VIEW_HOLDS permissions, rather than having to log in to a workstation
+at that library.
-- 
2.11.0