From 9bf50ce76379440f19a3b0d01558149acdd4e472 Mon Sep 17 00:00:00 2001
From: Terran McCanna <tmccanna@georgialibraries.org>
Date: Mon, 16 Sep 2019 15:45:52 -0400
Subject: [PATCH] LP#1843637 MARC View Display Issues

This fixes vertical alignment issues in the MARC View table
by removing the deprecated valign tags and moving the inline
CSS to the cat.css file. The text within each table cell should
now align to the top for better readability.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---
 Open-ILS/src/templates/staff/css/cat.css.tt2 | 22 ++++++++++++++++++++++
 Open-ILS/xsl/oilsMARC21slim2HTML.xsl         | 11 +++++------
 2 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/Open-ILS/src/templates/staff/css/cat.css.tt2 b/Open-ILS/src/templates/staff/css/cat.css.tt2
index 0b373e407d..ced13b3676 100644
--- a/Open-ILS/src/templates/staff/css/cat.css.tt2
+++ b/Open-ILS/src/templates/staff/css/cat.css.tt2
@@ -191,6 +191,28 @@ grid[name="-none-"] * label { color: black; }
     word-break: break-word;
 }
 
+.marc_tag_col {
+    text-align: right;
+    vertical-align: top;
+}
+
+.marc_tag_ind1 {
+    vertical-align: top;
+    padding-left: 3px;
+    padding-right: 3px;
+}
+
+.marc_tag_ind2 {
+    vertical-align: top;
+    border-left: 1px solid #A0A0A0;
+    padding-left: 3px;
+}
+
+.marc_subfields {
+    vertical-align: top;
+    padding-left: 3px;
+}
+
 /*
  * Holdings Editor Styles
  * /
diff --git a/Open-ILS/xsl/oilsMARC21slim2HTML.xsl b/Open-ILS/xsl/oilsMARC21slim2HTML.xsl
index 76bffcbc9d..373d0100fd 100644
--- a/Open-ILS/xsl/oilsMARC21slim2HTML.xsl
+++ b/Open-ILS/xsl/oilsMARC21slim2HTML.xsl
@@ -36,7 +36,7 @@
 	<xsl:template match="marc:record">
 		<table class='marc_table'>
 			<tr class='marc_tag_row'>
-				<th class='marc_tag_col' NOWRAP="TRUE" ALIGN="RIGHT" VALIGN="middle">
+				<th class='marc_tag_col' NOWRAP="TRUE">
 					LDR
 				</th>
 				<td class='marc_tag_data' COLSPAN='3'>
@@ -49,7 +49,7 @@
 	
 	<xsl:template match="marc:controlfield">
 		<tr class='marc_tag_row'>
-			<th class='marc_tag_col' NOWRAP="TRUE" ALIGN="RIGHT" VALIGN="middle">
+			<th class='marc_tag_col' NOWRAP="TRUE">
 				<xsl:value-of select="@tag"/>
 			</th>
 			<td class='marc_tag_data' COLSPAN='3'>
@@ -60,16 +60,15 @@
 	
 	<xsl:template match="marc:datafield">
 		<tr class='marc_tag_row'>
-			<th class='marc_tag_col' NOWRAP="TRUE" ALIGN="RIGHT" VALIGN="middle">
+			<th class='marc_tag_col' NOWRAP="TRUE">
 				<xsl:value-of select="@tag"/>
 			</th>
-			<td class='marc_tag_ind'>
+			<td class='marc_tag_ind1'>
 				<xsl:value-of select="@ind1"/>
 			</td>
 
-			<td class='marc_tag_ind' style='border-left: 1px solid #A0A0A0; padding-left: 3px;'>
+			<td class='marc_tag_ind2'>
 				<xsl:value-of select="@ind2"/>
-				<span style='color:#FFF'>.</span> 
 			</td>
 
 			<td class='marc_subfields'>
-- 
2.11.0