From 9d7eb0f3fc987311623d590ca94369d7e493e7bc Mon Sep 17 00:00:00 2001
From: dbs <dbs@6d9bc8c9-1ec2-4278-b937-99fde70a366f>
Date: Fri, 13 Nov 2009 00:18:09 +0000
Subject: [PATCH] Ensure that we unhide the rdetail_online_row if we resolve
 holdings, as the record might not have any 856s of its own

Use dojo.query().removeClass() throughout to unhide stuff


git-svn-id: svn://svn.open-ils.org/ILS-Contrib/conifer/trunk@716 6d9bc8c9-1ec2-4278-b937-99fde70a366f
---
 web/opac/skin/lul/xml/rdetail/rdetail_summary.xml | 34 ++++++++++++-----------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml b/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml
index 114f50c586..0e68ffcf57 100644
--- a/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml
+++ b/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml
@@ -40,7 +40,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.alternate.title;</td>
 				<td type='opac/slot-data' query='datafield[tag=246] subfield[code=a]' class='rdetail_item'>
 					<script type='opac/slot-format'><![CDATA[
-						unHideMe($('tag246'));
+						dojo.query('#tag246').removeClass('hide_me');
 						return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 					]]></script>
 				</td>
@@ -55,7 +55,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.author;</td>
 				<td type='opac/slot-data' query='datafield[tag=100]' class='rdetail_item'>
 					<script type='opac/slot-format'><![CDATA[
-						unHideMe($('tag100'));
+						dojo.query('#tag100').removeClass('hide_me');
 						return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 					]]></script>
 				</td>
@@ -64,7 +64,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.corporate.author;</td>
 				<td type='opac/slot-data' query='datafield[tag=110]' class='rdetail_item'>
 					<script type='opac/slot-format'><![CDATA[
-						unHideMe($('tag110'));
+						dojo.query('#tag110').removeClass('hide_me');
 						return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 					]]></script>
 				</td>
@@ -73,7 +73,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.meeting.name;</td>
 				<td type='opac/slot-data' query='datafield[tag=111]' class='rdetail_item'>
 					<script type='opac/slot-format'><![CDATA[
-						unHideMe($('tag111'));
+						dojo.query('#tag111').removeClass('hide_me');
 						return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 					]]></script>
 				</td>
@@ -82,7 +82,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.isbn;</td>			
 				<td type='opac/slot-data' query='datafield[tag=020]' class='rdetail_item'>
 				    <script type='opac/slot-format'><![CDATA[
-					unHideMe($('tag020'));
+					dojo.query('#tag020').removeClass('hide_me');
 					return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				    ]]></script>
 				</td>
@@ -92,8 +92,9 @@
 				<td nowrap='nowrap' class='rdetail_desc' id='issn_title'>&common.issn;</td>			
 				<td type='opac/slot-data' query='datafield[tag=022]' class='rdetail_item' id='rdetail_issn'>
 				    <script type='opac/slot-format'><![CDATA[
-					unHideMe($('tag022'));
+					dojo.query('#tag022').removeClass('hide_me');
 					var issn_raw = dojo.trim(dojox.data.dom.textContent(item));
+
 					// textContent returns multiple subfields concatenated with linefeeds,
 					// so our regex needs to match against linefeeds. "." does not match
 					// linefeeds, so get \s into the mix
@@ -114,6 +115,7 @@
 								+ entry.target_coverage
 								+ (entry.target_embargo ? (' / ' + entry.target_embargo) : '') 
 								+ '</div>', 'rdetail_online');
+							dojo.query('#rdetail_online_row').removeClass('hide_me');
 						});
 					}
 					req.send();
@@ -138,7 +140,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&common.publisher;</td>		
 				<td type='opac/slot-data' query='datafield[tag=260]' class='rdetail_item'>
 				    <script type='opac/slot-format'><![CDATA[
-					unHideMe($('tag260'));
+					dojo.query('#tag260').removeClass('hide_me');
 					return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				    ]]></script>
 			    </td> 
@@ -162,7 +164,7 @@
 				<td nowrap='nowrap' class='rdetail_desc'>&rdetail.detailMain.abstract;</td>	
 				<td type='opac/slot-data' query='datafield[tag=520]' class='rdetail_item'>
 				    <script type='opac/slot-format'><![CDATA[
-					unHideMe($('tag520'));
+					dojo.query('#tag520').removeClass('hide_me');
 					return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				    ]]></script>
 				</td>
@@ -175,7 +177,7 @@
 			 <td nowrap='nowrap' class='rdetail_desc'>&common.subjects;</td>
 			 <td type='opac/slot-data' query='datafield[tag^=65]' class='rdetail_item'>
 			 <script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag65_'));
+				dojo.query('#tag65_').removeClass('hide_me');
 				var cgi = new CGI();
 				var other_params = [ 'd', 'l', 'r', 'av', 's', 'sd' ];
 				var total = '';
@@ -199,7 +201,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.general.note;</td>
 			<td type='opac/slot-data' query='datafield[tag=500]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag500'));
+				dojo.query('#tag500').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
@@ -208,7 +210,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.contents.note;</td>
 			<td type='opac/slot-data' query='datafield[tag=505]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag505'));
+				dojo.query('#tag505').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
@@ -217,7 +219,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.usage.restrictions;</td>
 			<td type='opac/slot-data' query='datafield[tag=506] subfield[code=a]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag506'));
+				dojo.query('#tag506').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span> ';
 				]]></script>
 			</td>
@@ -226,7 +228,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.performer.note;</td>
 			<td type='opac/slot-data' query='datafield[tag=511]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag511'));
+				dojo.query('#tag511').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
@@ -235,7 +237,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.additional.authors;</td>
 			<td type='opac/slot-data' query='datafield[tag=700]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag700'));
+				dojo.query('#tag700').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
@@ -244,7 +246,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.preceding.entry;</td>
 			<td type='opac/slot-data' query='datafield[tag=780]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag780'));
+				dojo.query('#tag780').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
@@ -253,7 +255,7 @@
 			<td nowrap='nowrap' class='rdetail_desc'>&common.succeeding.entry;</td>
 			<td type='opac/slot-data' query='datafield[tag=785]' class='rdetail_item'>
 				<script type='opac/slot-format'><![CDATA[
-				unHideMe($('tag785'));
+				dojo.query('#tag785').removeClass('hide_me');
 				return '<span>' + dojox.data.dom.textContent(item) + '</span><br/>';
 				]]></script>
 			</td>
-- 
2.11.0