From 9d8c721fa9ac37879ac2299fed80eecef8c9a113 Mon Sep 17 00:00:00 2001
From: Chris Sharp <csharp@georgialibraries.org>
Date: Fri, 5 Aug 2016 09:27:23 -0400
Subject: [PATCH] LP#1610246 Classic Circulation View excluding circulations

The reporter.classic_current_circ view, which is available via
Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
circulations because it was assuming all users have a billing address
This branch corrects that with a LEFT JOIN.

No upgrade script will be included since these views are not assumed
to be installed by all Evergreen instances.  Please re-run the
example.reporter-extension.sql file to apply this change for your
instance.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
 Open-ILS/src/sql/Pg/example.reporter-extension.sql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Open-ILS/src/sql/Pg/example.reporter-extension.sql b/Open-ILS/src/sql/Pg/example.reporter-extension.sql
index 5095aeecf6..8cee578cb5 100644
--- a/Open-ILS/src/sql/Pg/example.reporter-extension.sql
+++ b/Open-ILS/src/sql/Pg/example.reporter-extension.sql
@@ -110,7 +110,7 @@ SELECT	cl.shortname AS circ_lib,
 	JOIN actor.org_unit hl ON (p.home_ou = hl.id)
 	JOIN permission.grp_tree g ON (p.profile = g.id)
 	JOIN reporter.demographic dem ON (dem.id = p.id)
-	JOIN actor.usr_address paddr ON (paddr.id = p.billing_address)
+	LEFT JOIN actor.usr_address paddr ON (paddr.id = p.billing_address)
 	LEFT JOIN config.language_map lm ON (rd.item_lang = lm.code)
 	LEFT JOIN config.lit_form_map lfm ON (rd.lit_form = lfm.code)
 	LEFT JOIN config.item_form_map ifm ON (rd.item_form = ifm.code)
-- 
2.11.0