From 9f28ee7ccb8dd7737106164f6ce8d2ca25f3d787 Mon Sep 17 00:00:00 2001
From: Ben Shum <bshum@biblio.org>
Date: Wed, 13 Feb 2013 10:30:47 -0500
Subject: [PATCH] TPAC - add "patron barcode not found" message to hold
 placement page

Add "Patron barcode not found" as an error text next to the barcode entry
when the lookup fails. This message helps warn staff that the barcode they
are attempting to use is not valid.

Signed-off-by: Ben Shum <bshum@biblio.org>
---
 Open-ILS/src/templates/opac/parts/place_hold.tt2 | 2 +-
 Open-ILS/web/js/ui/default/opac/staff.js         | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Open-ILS/src/templates/opac/parts/place_hold.tt2 b/Open-ILS/src/templates/opac/parts/place_hold.tt2
index c22dee43a3..5b6171b415 100644
--- a/Open-ILS/src/templates/opac/parts/place_hold.tt2
+++ b/Open-ILS/src/templates/opac/parts/place_hold.tt2
@@ -22,7 +22,7 @@
             <label for="hold_usr_is_requestor_not">
                 [% l("Place hold for patron by barcode:") %]
             </label>
-            <input type="text" name="hold_usr" id="hold_usr_input" onchange="staff_hold_usr_barcode_changed();" onkeypress="return no_hold_submit(event)" /> <span id="patron_name"></span><br />
+            <input type="text" name="hold_usr" id="hold_usr_input" onchange="staff_hold_usr_barcode_changed();" onkeypress="return no_hold_submit(event)" /> <span id="patron_name"></span><span id="patron_usr_barcode_not_found" style="display: none">[% l('Patron barcode was not found') %]</span><br />
             <input type="hidden" id="staff_barcode" value="[% ctx.staff_recipient.card.barcode | html %]"/>
             <span>
                 <input type="radio" id="hold_usr_is_requestor"
diff --git a/Open-ILS/web/js/ui/default/opac/staff.js b/Open-ILS/web/js/ui/default/opac/staff.js
index 0de11fb4b0..ce26e03349 100644
--- a/Open-ILS/web/js/ui/default/opac/staff.js
+++ b/Open-ILS/web/js/ui/default/opac/staff.js
@@ -52,6 +52,7 @@ function staff_hold_usr_barcode_changed(isload) {
         var load_info = xulG.get_barcode_and_settings(window, barcode, only_settings);
         if(load_info == false || load_info == undefined) {
             document.getElementById('patron_name').innerHTML = '';
+            document.getElementById("patron_usr_barcode_not_found").style.display = '';
             cur_hold_barcode = null;
             return;
         }
@@ -88,6 +89,7 @@ function staff_hold_usr_barcode_changed(isload) {
         for(var i in update_elements) update_elements[i].textContent = load_info.user_email;
         if(!document.getElementById('hold_usr_is_requestor').checked && document.getElementById('hold_usr_input').value) {
             document.getElementById('patron_name').innerHTML = load_info.patron_name;
+            document.getElementById("patron_usr_barcode_not_found").style.display = 'none';
         }
         // Ok, now we can allow submitting again, unless this is a "true" load, in which case we likely have a blank barcode box active
         if (isload !== true)
-- 
2.11.0