From 9f72997ad13f59d554cf547b546d20c439881c1b Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Mon, 12 Oct 2020 12:56:02 -0400 Subject: [PATCH] sip2 activity;repairs Signed-off-by: Bill Erickson --- Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm | 4 +++- .../src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm | 13 +++++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm index 799bd8abd0..a1023a869e 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm @@ -12,10 +12,10 @@ use OpenILS::Application::SIP2::Common; use OpenILS::Application::SIP2::Session; use OpenILS::Application::SIP2::Item; use OpenILS::Application::SIP2::Patron; + my $U = 'OpenILS::Application::AppUtils'; my $SC = 'OpenILS::Application::SIP2::Common'; - __PACKAGE__->register_method( method => 'dispatch_sip2_request', api_name => 'open-ils.sip2.request', @@ -43,6 +43,8 @@ __PACKAGE__->register_method( sub dispatch_sip2_request { my ($self, $client, $seskey, $message) = @_; + OpenSRF::AppSession->ingress('sip2'); + return OpenILS::Event->new('SIP2_SESSION_REQUIRED') unless $seskey; my $msg_code = $message->{code}; diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm index 2d711a0c41..0bc404d4fb 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm @@ -62,14 +62,19 @@ sub get_patron_details { set_patron_summary_items($session, $details, %params); set_patron_summary_list_items($session, $details, %params); - - $U->log_user_activity($patron->id, - $session->sip_account->activity_who || $session->config->{default_activity_who}, - 'verify'); + log_activity($session, $patron); return $details; } +sub log_activity { + my ($session, $patron) = @_; + + my $ewho = $session->sip_account->activity_who + || $session->config->{default_activity_who}; + $U->log_user_activity($patron->id, $ewho, 'verify'); +} + # Sets: # holds_count -- 2.11.0