From a064b057f87eb705102f5436318579d3d042307f Mon Sep 17 00:00:00 2001
From: Terran McCanna <tmccanna@georgialibraries.org>
Date: Wed, 30 Nov 2022 21:29:54 -0500
Subject: [PATCH] Online Renewal - Cleanup

- Get rid of subroutine I didn't end up using
- Make sure a user is logged in before showing the renewal form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
---
 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm | 7 +------
 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm   | 1 -
 Open-ILS/src/templates-bootstrap/opac/renew-account.tt2      | 3 ++-
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
index f64b030792..1a8177a93b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
@@ -3575,12 +3575,7 @@ sub check_account_exp {
         href="/eg/opac/renew-account"><i class="fas fa-user-cog"></i>Click here to renew your account</a></span>';
     }
 
-    return;
-}
-
-# PINES - if account is eligible to renew, pass patron data to vendor to populate form
-sub load_renew_account {
-    return;
+    return 1;
 }
 
 1;
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
index 1465f48c1d..128efd9a66 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Ecard.pm
@@ -105,7 +105,6 @@ sub log_params {
 
 #TERRAN - dump out all incoming stuff from form
 $logger->error("TERRAN - all incoming params: $msg");
-
 }
 
 sub handle_testmode_api {
diff --git a/Open-ILS/src/templates-bootstrap/opac/renew-account.tt2 b/Open-ILS/src/templates-bootstrap/opac/renew-account.tt2
index c093eabb80..0059a2865b 100644
--- a/Open-ILS/src/templates-bootstrap/opac/renew-account.tt2
+++ b/Open-ILS/src/templates-bootstrap/opac/renew-account.tt2
@@ -5,11 +5,11 @@
     ctx.page_title = l("Renew Your Library Card");
 %]
 
+[% IF ctx.user %]
 <!-- eCARD scripts here -->
 <script id="eRenewServer" src="https://ecard.quipugroup.net/js/eRenewEmbed.js"></script>
 <script>loadQGeRenew(48)</script>
 
-
 <h2 class="sr-only">[% l('Renew Your Library Card') %]</h2>
 
 <div id="content-wrapper">
@@ -34,4 +34,5 @@
         <div class="common-full-pad"></div>	
     </div>
 </div>
+[% END %]
 [%- END %]
-- 
2.11.0