From a1c8c3a7ade8b5f0c93af9832683bb151d3ce77f Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Tue, 25 Jun 2013 09:32:48 -0400 Subject: [PATCH] LP#1308239 Support pre-cat copy hold targeting Remove an unused line of code in the hold targeter which was preventing targeting of pre-cat copies. In OpenILS::Utils::PermitHold::permit_copy_hold, neither in-db nor script based hold viability checks inspect the value of the "title_descriptor" field in the provided params. Remove this field and pre-cats just work. Signed-off-by: Bill Erickson Signed-off-by: Ben Shum --- .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index 7cc2086efb..0452676b6a 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -1823,7 +1823,6 @@ sub new_hold_copy_targeter { ) && ( OpenILS::Utils::PermitHold::permit_copy_hold( { title => $old_best->call_number->record->to_fieldmapper, - title_descriptor => $old_best->call_number->record->record_descriptor->next->to_fieldmapper, patron => $hold->usr->to_fieldmapper, copy => $old_best->to_fieldmapper, requestor => $hold->requestor->to_fieldmapper, @@ -2260,7 +2259,6 @@ sub choose_nearest_copy { while (my ($c) = splice(@capturable, $rand, 1)) { return $c if !exists($seen{$c->id}) && ( OpenILS::Utils::PermitHold::permit_copy_hold( { title => $c->call_number->record->to_fieldmapper, - title_descriptor => $c->call_number->record->record_descriptor->next->to_fieldmapper, patron => $hold->usr->to_fieldmapper, copy => $c->to_fieldmapper, requestor => $hold->requestor->to_fieldmapper, -- 2.11.0