From abfa1eab40c9979fdac2baa184b1b969c72396d8 Mon Sep 17 00:00:00 2001 From: Kyle Huckins <khuckins@catalyte.io> Date: Thu, 7 Feb 2019 19:54:56 +0000 Subject: [PATCH] lp1806087 Place Holds Improvements - Disable SMS Carriers dropdown if Notify by SMS unchecked. - Move Search for patron button to same level as "Place Hold (name)" text. - Add Search icon to "Search for Patron" button - Add "Submit" button to Barcode input for improved UX. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Changes to be committed: modified: Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu> --- .../src/app/staff/catalog/hold/hold.component.html | 27 ++++++++++++++-------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html index 1ef096c495..998aa212fe 100644 --- a/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html +++ b/Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html @@ -1,9 +1,19 @@ - -<h3 i18n>Place Hold - <small *ngIf="user"> - ({{user.family_name()}}, {{user.first_given_name()}}) - </small> -</h3> +<div class="row"> + <div class="col-lg-3"> + <h3 i18n>Place Hold + <small *ngIf="user"> + ({{user.family_name()}}, {{user.first_given_name()}}) + </small> + </h3> + </div> + <div class="col-lg-3 text-right"> + <button class="btn btn-outline-dark btn-sm" + [disabled]="true" i18n> + <span class="material-icons mat-icon-in-button align-middle" title="Search for Patron">search</span> + <span class="align-middle">Search for Patron</span> + </button> + </div> +</div> <form class="form form-validated common-form" autocomplete="off" (keydown.enter)="$event.preventDefault()"> @@ -27,8 +37,7 @@ (keyup.enter)="userBarcodeChanged()" [(ngModel)]="userBarcode" (change)="userBarcodeChanged()"/> <div class="input-group-append"> - <button class="btn btn-outline-dark" - [disabled]="true" i18n>Search</button> + <button class="btn btn-outline-dark" (click)="userBarcodeChanged()">Submit</button> </div> </div> </div> @@ -134,7 +143,7 @@ <label i18n>SMS Carrier</label> </div> <div class="flex-1"> - <eg-combobox + <eg-combobox [disabled]="!notifySms" placeholder="SMS Carriers" i18n-placeholder [entries]="smsCarriers"> </eg-combobox> -- 2.11.0