From ad5f7d067cefe51675897ce1f2ac3f22552027ff Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Sun, 1 Nov 2020 11:02:53 -0500 Subject: [PATCH] LP1901930 SIP2Mediator checkin support Signed-off-by: Bill Erickson --- Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm | 5 ----- .../src/perlmods/lib/OpenILS/Application/SIP2/Checkin.pm | 12 ------------ 2 files changed, 17 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm index 44109be0ee..7612303d1f 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm @@ -498,11 +498,6 @@ sub handle_checkin { my $hold_bc = $checkin_details->{hold_patron_barcode}; my $hold_name = $checkin_details->{hold_patron_name}; - # XXX - use OpenSRF::Utils::JSON; - $logger->info('SIP checkin details ' . OpenSRF::Utils::JSON->perl2JSON($checkin_details)); - $logger->info('SIP item details ' . OpenSRF::Utils::JSON->perl2JSON($item_details)); - return { code => '10', fixed_fields => [ diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkin.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkin.pm index 326019f484..cb042ca929 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkin.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkin.pm @@ -20,21 +20,14 @@ sub checkin { my $details = {}; my $override = 0; - use OpenSRF::Utils::JSON; - $logger->info('SIP checkin details 1' . OpenSRF::Utils::JSON->perl2JSON($details)); - for (0, 1) { # 2 checkin requests max $override = $class->perform_checkin($session, $details, $override, %params); - $logger->info('SIP checkin details 5' . OpenSRF::Utils::JSON->perl2JSON($details)); - last unless $override; } - $logger->info('SIP checkin details 6' . OpenSRF::Utils::JSON->perl2JSON($details)); - return $details; } @@ -65,9 +58,6 @@ sub perform_checkin { # Treat the first response as the main result. my $event = ref $resp eq 'ARRAY' ? $resp->[0] : $resp; - $logger->info('SIP checkin details 3' . OpenSRF::Utils::JSON->perl2JSON($details)); - $logger->info('SIP checkin details event' . OpenSRF::Utils::JSON->perl2JSON($event)); - return unless $U->is_event($event); # should never happen; fail gracefully my $textcode = $event->{textcode}; @@ -129,8 +119,6 @@ sub handle_hold { return unless $hold; - $logger->info('SIP checkin details 4' . OpenSRF::Utils::JSON->perl2JSON($details)); - my ($pickup_lib_id, $pickup_lib_sn); my $holder = $session->editor->retrieve_actor_user( -- 2.11.0