From ad604edf81b593983cbc51343b8f858e26a8dd9c Mon Sep 17 00:00:00 2001 From: Cesar Velez Date: Mon, 5 Feb 2018 17:45:22 -0500 Subject: [PATCH] LP#1746815: Fix sticky hold url param Renamed the hold_id url param from "id" to "hid" and prevent it from sticking in url's where it not needed. To test ------- [1] Log in to the public catalog as a patron that has at least two hold requests. [2] Go to the My Account holds tab and edit one of the holds. [3] Rather than submit a change, click on the holds tab again. [4] Note that /only/ the hold you were edit displays, and that the 'id' URL parameter persists as you navigate through the public catalog. [5] Apply the patch and repeat steps 1-3. This time, you should see all of the holds. Signed-off by: Cesar Velez Signed-off-by: Michele Morgan Signed-off-by: Galen Charlton --- .../src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm | 2 +- Open-ILS/src/templates/opac/myopac/holds.tt2 | 2 +- Open-ILS/src/templates/opac/parts/myopac/base.tt2 | 4 ++-- Open-ILS/src/templates/opac/parts/topnav.tt2 | 14 +++++++------- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm index b6305175ed..027948b1e8 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm @@ -951,7 +951,7 @@ sub load_myopac_holds { my $limit = $self->cgi->param('limit') || 15; my $offset = $self->cgi->param('offset') || 0; my $action = $self->cgi->param('action') || ''; - my $hold_id = $self->cgi->param('id'); + my $hold_id = $self->cgi->param('hid'); my $available = int($self->cgi->param('available') || 0); my $hold_handle_result; diff --git a/Open-ILS/src/templates/opac/myopac/holds.tt2 b/Open-ILS/src/templates/opac/myopac/holds.tt2 index 5a0c3c41d0..d881d9f3a3 100644 --- a/Open-ILS/src/templates/opac/myopac/holds.tt2 +++ b/Open-ILS/src/templates/opac/myopac/holds.tt2 @@ -252,7 +252,7 @@ [%- END; END; %] - [% l('Edit') %] diff --git a/Open-ILS/src/templates/opac/parts/myopac/base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/base.tt2 index 94259db309..15cf56e628 100644 --- a/Open-ILS/src/templates/opac/parts/myopac/base.tt2 +++ b/Open-ILS/src/templates/opac/parts/myopac/base.tt2 @@ -37,7 +37,7 @@ ELSE; cls_which = "acct-tab-off"; END -%] - [% page.name; %] [% END %] @@ -52,7 +52,7 @@ [% FOREACH page IN myopac_pages; IF page.url != myopac_page; %] - + [% ELSE; %] [% END; diff --git a/Open-ILS/src/templates/opac/parts/topnav.tt2 b/Open-ILS/src/templates/opac/parts/topnav.tt2 index e84fbca781..68fd3bb238 100644 --- a/Open-ILS/src/templates/opac/parts/topnav.tt2 +++ b/Open-ILS/src/templates/opac/parts/topnav.tt2 @@ -24,7 +24,7 @@ |