From b0f56f96df65fd28d8ec47491a413967145b8476 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Fri, 11 Feb 2022 10:45:51 -0500 Subject: [PATCH] LP#1939338: fix IDL mistake that could prevent admin of carousels This patch fixes a typo found in the IDL definition of the classes for bib, call number, item, and user buckets. One effect of the typo is that the admin interface for carousels could not flesh out the record buckets unless the staff user was either a global administrator or was the one who had created the carousel and bucket originally. This patch likely fixes other cases where one would expect to be able to access buckets created by another user. This patch is effectively a subset of a patch in the Simple Reporter branch (bug 1945836 and working repository commit 36369719067) that addresses several more errors in the IDL. However, I'm submitting this one now in the hopes of resolving a long-standing bug with carousels sooner rather than later. To test ------- [1] As a local admin, create a carousel definition. [2] As a different local admin at the same OU, open the carousels admin interface. Note that attempting to retrieve carousel defs created in step 1 will result in a console error and the interface not being completely rendered. [3] Apply the patch and repeat step 2. This time, the carousel definitions should all display. Signed-off-by: Galen Charlton Signed-off-by: Andrea Buntz Neiman Signed-off-by: Mike Rylander --- Open-ILS/examples/fm_IDL.xml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml index d73d8df351..aa658bac87 100644 --- a/Open-ILS/examples/fm_IDL.xml +++ b/Open-ILS/examples/fm_IDL.xml @@ -5686,10 +5686,10 @@ SELECT usr, - - - - + + + + @@ -7305,10 +7305,10 @@ SELECT usr, - - - - + + + + @@ -7440,10 +7440,10 @@ SELECT usr, - - - - + + + + @@ -8495,10 +8495,10 @@ SELECT usr, - - - - + + + + -- 2.11.0