From b110c9b5bca0f18ca6d0cddd0143ba59c23a30fd Mon Sep 17 00:00:00 2001
From: Jessica Woolford <jwoolford@biblio.org>
Date: Tue, 13 Dec 2022 14:41:44 -0500
Subject: [PATCH] LP # 1814966: No popup warning for invalid barcode

Adds a check for an invalid barcode if "Use Checkdigit" is selected.
Prevents saving if the check fails.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
---
 Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.html | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.html b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.html
index 0e9142daad..6f2b0d047a 100644
--- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/vol-edit.component.html
@@ -402,7 +402,7 @@
               placeholder="New Barcode..." i18n-placeholder
               [disabled]="volcopy.copyStatIsMagic(copyNode.target.status())"
               [ngClass]="{
-                'text-danger': copyNode.target._dupe_barcode,
+                'text-danger': copyNode.target._dupe_barcode || copyNode.target._bad_barcode,
                 'invalid': !copyNode.target.barcode() && !copyNode.target.isnew()
               }"
               (change)="barcodeChanged(copyNode.target, $event.target.value)"  
@@ -417,6 +417,10 @@
             class="alert alert-danger font-italic p-1" i18n>
             Duplicate Barcode
           </div>
+          <div *ngIf="copyNode.target._bad_barcode"
+          class="alert alert-danger font-italic p-1" i18n>
+          Invalid Barcode
+        </div>  
         </div>
         <div class="p-1" [ngStyle]="{flex: flexAt(9)}">
           <ng-container *ngIf="displayColumn('copy_number_vc')">
-- 
2.11.0